- Issue created by @joecorall
- πΊπΈUnited States joecorall
joecorall β changed the visibility of the branch 10.2.x to hidden.
- Merge request !7786Only attempt to delete the config export if the file exist β (Open) created by joecorall
- Status changed to Needs review
4 months ago 9:23am 27 April 2024 - πΊπΈUnited States joecorall
Did an export at https://mr7786-fplkwrzyzaxesdidfzoff564jkup2gya.tugboatqa.com/admin/conf... successfully and no watchdog entries at https://mr7786-fplkwrzyzaxesdidfzoff564jkup2gya.tugboatqa.com/admin/repo...
- πΊπΈUnited States joecorall
- Status changed to Needs work
4 months ago 5:12pm 27 April 2024 - πΊπΈUnited States smustgrave
Thanks for reporting. Will need test coverage
Also changing to current development branch.
- Status changed to Needs review
4 months ago 8:33pm 27 April 2024 - πΊπΈUnited States joecorall
Thanks for the review! I added a test I ran locally before the bugfix was applied that failed. Applied the bugfix from this MR, reran the test, and it passed. The MR is failing at https://git.drupalcode.org/issue/drupal-3443874/-/jobs/1453157#L91 but I think that's unrelated.
$ php ./core/scripts/run-tests.sh \ --verbose \ --dburl "sqlite://localhost/drupal:drupal@127.0.0.1:3306/drupal" \ --url http://localhost:8888/ \ --sqlite "/tmp/test.sqlite" \ --class "Drupal\Tests\config\Functional\ConfigExportUITest" Drupal test run --------------- Tests to be run: - Drupal\Tests\config\Functional\ConfigExportUITest Test run started: Saturday, April 27, 2024 - 19:09 Test summary ------------ Drupal\Tests\config\Functional\ConfigExportUITest 1 passes Test run duration: 4 sec Detailed test results --------------------- ---- Drupal\Tests\config\Functional\ConfigExportUITest ---- Status Group Filename Line Function -------------------------------------------------------------------------------- Pass Other ConfigExportUITes 48 Drupal\Tests\config\Functional\Conf
- Status changed to Needs work
4 months ago 2:58pm 28 April 2024 - πΊπΈUnited States smustgrave
Ran test-only https://git.drupalcode.org/issue/drupal-3443874/-/jobs/1453155 to show coverage
But as far as the failure goes I've reran 3 times and they fail each time but then realized the MR is pointing to 10.2. Should point to 11.x and can be backported on commit.
- Status changed to Needs review
4 months ago 5:49pm 28 April 2024 - πΊπΈUnited States joecorall
Thanks for your help reviewing and walking me through this (my first MR to core). Much appreciated! I updated the target and rebased.
- Status changed to RTBC
4 months ago 5:54pm 28 April 2024 - πΊπΈUnited States smustgrave
No problem. 11.x is the current development branch. Bugs will be backported to supported branches at the time. Glad changing the target didn't break anything.
Fix LGTM.
- Status changed to Closed: outdated
4 months ago 11:28pm 29 April 2024 - π¬π§United Kingdom alexpott πͺπΊπ
The delete call no longer logs - so the test does not fail on 11.x - see https://git.drupalcode.org/issue/drupal-3443874/-/jobs/1457775.
Also see π Remove dependency of "file_system" service on "logger" Needs work - so this is fixed in 10.3.x so this is a closed won't fix. Thanks @joecorall for working on this but lucky this has already been fixed but another way!
- π¬π§United Kingdom alexpott πͺπΊπ
Also @joecorall just noticed that this is your first MR to core. Thanks for working on this. I know it can be very frustrating when the ground moves under your feet so to speak but at least the bug you noticed has been fixed and I hope the process is not disheartening. If you do work on a new MR please ping me on slack β and I'll do a review asap.
- πΊπΈUnited States smustgrave
That's my fault btw @joecorall when I asked to update the MR target I should of asked if a problem in 11.x. But will echo @alexpott thanks for working on the issue and especially thanks for addressing the feedback so quickly.