πŸ‡ΊπŸ‡ΈUnited States @joecorall

Account created on 31 January 2011, about 14 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States joecorall

Fixed with latest release 1.0.3. Thank you for reporting!

πŸ‡ΊπŸ‡ΈUnited States joecorall

Thanks for confirming. Looks like a code change was made on the dependent module: https://git.drupalcode.org/project/turnstile/-/commit/55638999e8ed960582...

I'll get a patch in

πŸ‡ΊπŸ‡ΈUnited States joecorall

I agree there could be better requirements checking/alerting for this module.

Though this module's instructions do say you need to configure the turnstile module's settings (at /admin/config/people/captcha/turnstile). As a stop-gap around this issue before adding better checks, have you done that?

πŸ‡ΊπŸ‡ΈUnited States joecorall

Thank you for reporting this issue. We took an alternate approach to resolve this bug: https://github.com/Islandora/jsonld/pull/85

πŸ‡ΊπŸ‡ΈUnited States joecorall

I am not sure I understand why having <front> protected is a problem?

πŸ‡ΊπŸ‡ΈUnited States joecorall

Had the same issue here after a composer update to 2.2.0-beta1. Applied the patch in this PR and the issue is resolved.

πŸ‡ΊπŸ‡ΈUnited States joecorall

Thank you for the bug report. Please update the module to alpha11 and the issue should be resolved.

πŸ‡ΊπŸ‡ΈUnited States joecorall

joecorall β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States joecorall

joecorall β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States joecorall

Thanks for the patch and improved performance!

πŸ‡ΊπŸ‡ΈUnited States joecorall

joecorall β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States joecorall

joecorall β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States joecorall

joecorall β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States joecorall

Duplicate of https://www.drupal.org/project/turnstile_protect/issues/3483806 πŸ“Œ Automated Drupal 11 compatibility fixes for turnstile_protect Needs review

πŸ‡ΊπŸ‡ΈUnited States joecorall

joecorall β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States joecorall

Putting this back to RTBC

πŸ‡ΊπŸ‡ΈUnited States joecorall

@ankitv18 - do you still feel this needs work?

πŸ‡ΊπŸ‡ΈUnited States joecorall

Thanks for your help reviewing and walking me through this (my first MR to core). Much appreciated! I updated the target and rebased.

πŸ‡ΊπŸ‡ΈUnited States joecorall

Thanks for the review! I added a test I ran locally before the bugfix was applied that failed. Applied the bugfix from this MR, reran the test, and it passed. The MR is failing at https://git.drupalcode.org/issue/drupal-3443874/-/jobs/1453157#L91 but I think that's unrelated.

$ php ./core/scripts/run-tests.sh \
  --verbose \
  --dburl "sqlite://localhost/drupal:drupal@127.0.0.1:3306/drupal" \
  --url http://localhost:8888/ \
  --sqlite "/tmp/test.sqlite" \
  --class "Drupal\Tests\config\Functional\ConfigExportUITest"

Drupal test run
---------------

Tests to be run:
  - Drupal\Tests\config\Functional\ConfigExportUITest

Test run started:
  Saturday, April 27, 2024 - 19:09

Test summary
------------

Drupal\Tests\config\Functional\ConfigExportUITest              1 passes                                      

Test run duration: 4 sec

Detailed test results
---------------------


---- Drupal\Tests\config\Functional\ConfigExportUITest ----


Status    Group      Filename          Line Function                            
--------------------------------------------------------------------------------
Pass      Other      ConfigExportUITes   48 Drupal\Tests\config\Functional\Conf
πŸ‡ΊπŸ‡ΈUnited States joecorall

joecorall β†’ changed the visibility of the branch 10.2.x to hidden.

πŸ‡ΊπŸ‡ΈUnited States joecorall

Revisiting the Google Cloud Storage docs, discovered the max upload size for a single file is 5GB, so increased the max upload size to 5GB in alpha10 release. We should still add multi part upload support so we can allow uploading 5TB files.

πŸ‡ΊπŸ‡ΈUnited States joecorall

Thanks for the MR @dakruchko. It's been merged.

πŸ‡ΊπŸ‡ΈUnited States joecorall

Thank you for the patch! It's been applied to alpha7 release.

πŸ‡ΊπŸ‡ΈUnited States joecorall

Thank you Seth for reporting and @code_brown for the patch. The patch has been merged and beta12 released with the fix.

πŸ‡ΊπŸ‡ΈUnited States joecorall

8.x-1.x was the core 8.x branch. It will not be upgraded to d10

πŸ‡ΊπŸ‡ΈUnited States joecorall

Thanks @pdcarto. Given these changes haven't been tested, I reverted the MR. Happy to merge changes for your use case if another MR is submitted.

πŸ‡ΊπŸ‡ΈUnited States joecorall

Thanks for the MR! It's been merged.

πŸ‡ΊπŸ‡ΈUnited States joecorall

Thanks for the MR. I merged it into the dev version. I am going to test this for the known node case. The code was designed to possibly support entity types other that nodes, but to my knowledge that use case never presented itself until what looks like now. So the other entity type support with solr was more theoretical. I am going to make sure this doesn't cause any regressions then cut a new release.

πŸ‡ΊπŸ‡ΈUnited States joecorall

joecorall β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States joecorall

This fix is in the latest release. Thanks for the patch!

πŸ‡ΊπŸ‡ΈUnited States joecorall

Thanks, everyone! Just cut a new release with this fix.

Production build 0.71.5 2024