Allow s-maxage to be overridden

Created on 22 November 2023, 7 months ago

Updated 26 April 2024, 2 months ago

Problem/Motivation

If a controller response is setting s-maxage, that value should be respected over the global value.

Steps to reproduce

Set s-maxage in a custom Controller response that is a value other than what's set by this module, and see this module's global value is what is used.

    $response = new CacheableJsonResponse($response);
    $response->headers->set('Cache-Control', 's-maxage=900');
    return $response;

Proposed resolution

Check if this header is set, and only add this module's value if it is not.

🐛 Bug report

Status

RTBC

Version

2.0

Component

Code

Created by

🇺🇸United States joecorall

Live updates comments and jobs are added and updated live.

Merge Requests

!8Allow s-maxage to be overridden
Open
🇺🇸United States joecorall
updated 7 months ago

Comments & Activities

Issue created by @joecorall
Merge request !8Issue #3403417: Allow s-maxage to be overridden → (Open) created by joecorall
Status changed to Needs review 7 months ago3:27pm 22 November 2023
Comment 7 months ago →
🇺🇸United States joecorall
Status changed to RTBC 2 months ago5:53pm 26 April 2024
Comment 2 months ago →
🇸🇮Slovenia useernamee Ljubljana
I found this patch and it is exactly what we were looking for. RTBC.
Comment 2 months ago →
🇦🇹Austria fago Vienna
I agree it makes sense to allow specialized controllers to take control. Patch is good and works as it should.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024