- Issue created by @quietone
- Merge request !7726Resolve #3443445 "Use drupal.namingconventions.validfunctionname in" β (Open) created by quietone
- Status changed to Needs review
4 months ago 9:39am 26 April 2024 - Status changed to RTBC
4 months ago 1:05pm 26 April 2024 - πΊπΈUnited States smustgrave
Tests are all green, with the rule enabled should be able to see failures
Wonder if follow ups will eventually be needed for the ones that are being ignored? Not sure the plan there.
But overall looks fine.
- π³πΏNew Zealand quietone New Zealand
@smustgrave, your question is answered in the issue summary.
- π¦πΊAustralia mstrelan
I struggle with some of these. For example Mtime, should that be changed to ModifiedTime?
- πΊπΈUnited States smustgrave
Can say if you gave me those function names without looking I would never guess mtime is modified time
- π¦πΊAustralia mstrelan
atime, mtime and ctime are all common unix terms. FWIW symfony response class has methods to get and set the s-max-age header and are named getSharedMaxAge and setSharedMaxAge, rather than getSmaxAge that this convention would enforce.
- π³πΏNew Zealand quietone New Zealand
Yes, some of these are unexpected, like 'Mtime'. If we change the names of the methods then we would have to do deprecations so that would be in a different issue.
I take the view that it is better to get the sniff enabled to prevent future problems. And names that people want to change change can be addressed in some followup or followups.
- Status changed to Needs review
4 months ago 9:25am 28 April 2024 - π¬π§United Kingdom alexpott πͺπΊπ
I posted in π [meta] Fix 'Drupal.NamingConventions.ValidFunctionName' coding standard Active - I'm not sure that this standard is a correct standard.
- Status changed to Postponed
4 months ago 2:29pm 28 April 2024 - πΊπΈUnited States smustgrave
To avoid cross conversations between tickets going to postpone all except π Use 'Drupal.NamingConventions.ValidFunctionName' in core/tests RTBC