Use 'Drupal.NamingConventions.ValidFunctionName' in non tests

Tests are all green, with the rule enabled should be able to see failures

Wonder if follow ups will eventually be needed for the ones that are being ignored? Not sure the plan there.

But overall looks fine.

@smustgrave, your question is answered in the issue summary.

I struggle with some of these. For example Mtime, should that be changed to ModifiedTime?

Can say if you gave me those function names without looking I would never guess mtime is modified time

atime, mtime and ctime are all common unix terms. FWIW symfony response class has methods to get and set the s-max-age header and are named getSharedMaxAge and setSharedMaxAge, rather than getSmaxAge that this convention would enforce.

Yes, some of these are unexpected, like 'Mtime'. If we change the names of the methods then we would have to do deprecations so that would be in a different issue.

I take the view that it is better to get the sniff enabled to prevent future problems. And names that people want to change change can be addressed in some followup or followups.

#9 sounds good to me.

I posted in 📌 [meta] Fix 'Drupal.NamingConventions.ValidFunctionName' coding standard Active - I'm not sure that this standard is a correct standard.

To avoid cross conversations between tickets going to postpone all except 📌 Use 'Drupal.NamingConventions.ValidFunctionName' in core/tests RTBC