TypeError: Drupal\scheduler_content_moderation_integration\EventSubscriber\SchedulerEventSubscriber::publishImmediately()

I think MR56 does not have the correct commits. Is the base branch set wrongly? There are 22 commits in it.

Also, just wondering if the error reported here is related to the recent change in Scheduler 🐛 SchedulerManager should take an EventDispatcherInterface object, not ContainerAwareEventDispatcher Fixed

Hi@jonathan1055,
i have fixed this issue "TypeError: Drupal\scheduler_content_moderation_integration\EventSubscriber\SchedulerEventSubscriber::publishImmediately()" and also attached patch ,kindly review and verify .

Fix should be in MR. #8 is just a use statement.

The #8 patch resolves the issue. The change in use statement appears to be all that is needed.

If @jonathan1055 in #7 is correct when the change was made in the parent scheduler module, I think this patch effectively now makes the module require version 2.0.2 of the scheduler module.

Is that considered a BC? Should the composer.json be updated to set that as the minimum scheduler module version?

I'm happy to convert the patch to a MR with changes.

The merge request is agains the wrong branch. I can't fix it, probably only the author and maintainers can. Can't find an option to start new MR from the same fork either.

Setting the 2.x branch as default might prevent mistakes like this.

@jonathan1055, @smustgrave Can anyone of you look into this?

Just watching this. As a new contributor I made the wrong branch merge mistake already. Maybe I can learn something here.

rafal.sereda → made their first commit to this issue’s fork.

rafal.sereda → changed the visibility of the branch 3442694- to hidden.

rafal.sereda → closed merge request !61

Aah, right, so the 2.x branch already has this fix..

So which one should we test?

Hey together,

this got my attention due to our addtion of this module in some customer projects.
I think this is already fixed by #3444174: Tests fail with "Call to a member function isPublished() on bool" → and we just need a new release.

So I will close this as outdated and add a issue relation.

sunlix → changed the visibility of the branch 3442694-typeerror-drupalschedulercontentmoderationintegrationeventsubscriberschedulereventsubscriberpublishimmediately to hidden.