- Issue created by @gcb
- First commit to issue fork.
- last update
8 months ago 227 pass - πΊπΈUnited States jrockowitz Brooklyn, NY
We should use the Symfony\Component\EventDispatcher\EventDispatcherInterface to maintain backward compatibility.
- Status changed to RTBC
7 months ago 2:25pm 15 April 2024 - last update
7 months ago Patch Failed to Apply - last update
7 months ago 227 pass - πΊπΈUnited States phenaproxima Massachusetts
I'm running into this on my project. Patch looks okay to me; I'm not sure if you're running CI, but I'll tentatively RTBC.
- Status changed to Needs work
7 months ago 7:21am 16 April 2024 - π¬π§United Kingdom jonathan1055
Hi gcb, jrockowitz and phenaproxima,
Thanks for working on this. But I am surprised at the issue summary "on a new site with Drupal 10.2.4 ..." is that really correct? Maybe you mean 10.3 or 11.x? Anyway, there is clearly something to fix here, so please can you open a Merge Request so that we can see the gitlab pipeline. Patch testing on drupal.org is being phased out, and all the development here should now be on MRs.
Thanks - Status changed to RTBC
7 months ago 10:49am 16 April 2024 - πΊπΈUnited States phenaproxima Massachusetts
Hi @jonathan1055 - there is a merge request open and CI is passing. You can see this at the top of this issue. But, for reference...
The merge request: https://git.drupalcode.org/project/scheduler/-/merge_requests/128
The passing tests: https://git.drupalcode.org/issue/scheduler-3437739/-/pipelines/139271
I'm hiding the patches, though, for clarity.
- last update
7 months ago 227 pass - last update
7 months ago 227 pass - π¬π§United Kingdom jonathan1055
Thanks. Sorry I don't know why I missed it. I have rebase the MR and running the pipeline again.
- π¬π§United Kingdom jonathan1055
In your previous test run, the phpunit tests are only run automatically at the current core version, 10.2 and they pass of course. But the "next minor" phpunit, for core 10.3, have to be triggered manually.
- π¬π§United Kingdom jonathan1055
The tests at 10.3 still have deprecations, but the actual tests run.
I need to verify if this change is OK at "previous minor" core 10.1 and "previous major" Core 9.5.11 before I commit.
I ran in to a problem with doing that, which I reported on π All variants run the same Drupal version when the pipeline is triggered via web Fixed . It seems that running a pipeline manually from the Web UI is not compatible with the Core variants.
- last update
7 months ago 227 pass - last update
7 months ago 227 pass -
jonathan1055 β
committed 31b0918e on 2.x authored by
jrockowitz β
Issue #3437739 by jonathan1055, jrockowitz, gcb, phenaproxima:...
-
jonathan1055 β
committed 31b0918e on 2.x authored by
jrockowitz β
- Status changed to Fixed
7 months ago 2:55pm 18 April 2024 - π¬π§United Kingdom jonathan1055
All passed at previous versions
https://git.drupalcode.org/project/scheduler/-/pipelines/150255Merged. Thank you for working on this. I will make a new release tomorrow.
Automatically closed - issue fixed for 2 weeks with no activity.
- Merge request !168Issue #3437739 Change ContainerAwareEventDispatcher to EventDispatcherInterface β (Merged) created by jonathan1055
- Status changed to Fixed
3 months ago 12:32pm 13 August 2024 - π¬π§United Kingdom jonathan1055
Backported to 8.x-1.x
https://git.drupalcode.org/project/scheduler/-/commit/28902d0e64f70894b3... Automatically closed - issue fixed for 2 weeks with no activity.