- Issue created by @quietone
- Status changed to Active
5 months ago 12:51pm 22 April 2024 - Merge request !7652Issue #3442530: Removed deprecated code in contextual module β (Closed) created by smustgrave
- πΊπΈUnited States smustgrave
Is this postponed on π Replace Contextual Links BackboneJS usage with VanillaJS equivalent Needs work
- πΊπΈUnited States smustgrave
Going to scope creep a little here but toolbar has 1 deprecation.
- Status changed to Needs work
5 months ago 9:48am 23 April 2024 - Merge request !7713Resolve #3442530 "Update contextual deprecation" β (Closed) created by smustgrave
- Status changed to Needs review
5 months ago 7:21pm 24 April 2024 - πΊπΈUnited States smustgrave
Extended contextual js deprecations to 12. Removed toolbars 1 instances.
- Status changed to Needs work
5 months ago 7:45pm 24 April 2024 - π«π·France andypost
As discussed deprecation for 12.x o contextual libs should have related 10.3.x MR to to keep changes the same
- Status changed to Needs review
5 months ago 8:34pm 24 April 2024 - Status changed to RTBC
5 months ago 8:36pm 24 April 2024 - π³πΏNew Zealand quietone New Zealand
As discussed deprecation for 12.x o contextual libs should have related 10.3.x MR to to keep changes the same
Where is this discussion? I can't find it.
This needs an explanation in the Issue Summary of why the deprecation notices are changed. Plus the title is incorrect.
- Status changed to Needs work
5 months ago 11:34pm 24 April 2024 - Status changed to Needs review
5 months ago 11:40pm 24 April 2024 - π«π·France andypost
In slack https://drupal.slack.com/archives/C04CHUX484T/p1713984272075489?thread_t...
I think contextual needs to stay a deprecation but change the removal date to 12.x, not sure because js though.. but also that's safer so we don't have to redeprecate when we actually remove it
- Status changed to RTBC
5 months ago 12:49am 25 April 2024 - Status changed to Needs work
5 months ago 12:55am 25 April 2024 - π³πΏNew Zealand quietone New Zealand
@andypost, thank you! To complete that quote it was from a release manager, catch.
Well the title is wrong for 10.3. This is a bit messy. I suggest moving toolbar to a deprecation removal issue and this is just for updating the deprecation notices for 10.3 and 11.
- πΊπΈUnited States smustgrave
Seems like overkill since toolbar has one deprecation.
- Assigned to andypost
- π«π·France andypost
extracted π Removed deprecated code in toolbar module Needs review
updated MR, IS and title
- Issue was unassigned.
- Status changed to Needs review
5 months ago 4:19pm 25 April 2024 - Status changed to RTBC
5 months ago 4:57pm 25 April 2024 - π¬π§United Kingdom catch
Double checked with nod_ and he confirmed all we can do is shift the deprecation for now. Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!
- Status changed to Fixed
5 months ago 7:33pm 25 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.