Fix schema and other test issues

Kinda stuck here with the whole schema definition....

Drupal\Tests\billwerk_subscriptions\Functional\BillwerkSubscriptionsGenericTest::testModuleGenericIssues
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for system.action.billwerk_user_contract_ids_clear_action with the following errors: system.action.billwerk_user_contract_ids_clear_action:configuration missing schema

I doubt, that I need to define a system schema. Especially for an action which is basically untouched and doesn't have a "configuration" property.

UPDATE: Found it! Inside "config/optional/system.action.billwerk_subscriptions_fetch_and_assing_billwerk_contract_ids.yml", we had the following entry:

configuration:
  overwrite_existing: false

This doesn't make sense, as the action doesn't have any configuration.

Ok, I still don't get the issue mentioned in #3 🐛 Fix schema and other test issues Active . I disabled schema validation and now we get the error message from 🐛 Enabling the "billwerk_subscriptions_entities" throws an error and undocumentet d Active , so I'll postpone this issue on that one for now.

Grevil → closed merge request !25

I would suggest actually adding the preUninstallSteps to a custom uninstall hook, this way, we do not define a test workaround but actually fix the problem.
There is also the possibility to add a dependency on the module itself. But this doesn't fix the issue. Please review

Eventually we can also leave this MR as is, as it might destroy the site to simply delete these configurations in an uninstall hook.

@Grevil let's discuss and finish this tomorrow!

@Grevil: I guess this is similar to 🐛 Trying to reinstall the "billwerk_subscriptions_entities" leads to configuration errors Active ?

Indeed!

Anybody → changed the visibility of the branch billwerk_subscriptions-3442075-3442075-fix-using-enforced-config-dependencies to hidden.

Anybody → changed the visibility of the branch 1.x to hidden.

Wrong branch! :P
I'll quickly cherry pick the commit.

Hm, patch doesn't apply...

Anybody → changed the visibility of the branch 3442075-fix-schema-NEW to hidden.

Enforced dependencies were a great idea! I also found some minor issues in the configs I fixed. Merging!

Automatically closed - issue fixed for 2 weeks with no activity.

anybody → closed merge request !39

anybody → closed merge request !33