- Issue created by @Anybody
- First commit to issue fork.
- Merge request !23Issue #3439604 by Grevil, Anybody: Final code style cleanup → (Merged) created by Grevil
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 3:04pm 16 April 2024 - 🇩🇪Germany Grevil
Alright, all done.
Eslint, stylelint and cspell are still open, but I fixed phpstan and phpcs issues.
- Assigned to Grevil
- Status changed to Needs work
about 1 year ago 3:11pm 17 April 2024 - 🇩🇪Germany Grevil
Everything green now!
As discussed internally with @Anybody, we will also implement the tests inside this issue here. :)
- Issue was unassigned.
- Status changed to Needs review
12 months ago 9:43am 19 April 2024 - 🇩🇪Germany Grevil
Ok, this requires too many changes that need to be properly reviewed.
Let's resolve the schema errors in a follow-up issue. Please review!
- Status changed to RTBC
12 months ago 9:59am 19 April 2024 - 🇩🇪Germany Anybody Porta Westfalica
Whao. LGTM, just see the comments please.
Any risky changes?
- Assigned to Anybody
- Status changed to Needs review
12 months ago 10:46am 19 April 2024 - 🇩🇪Germany Grevil
Alright, I just took a look at all the changes and made a few tiny adjustments. Also added a comment. Please resolve the comment @Anybody and give your final review!
- 🇩🇪Germany Grevil
Follow-up issue #1: 🐛 Fix schema and other test issues Active
Follow-up issue #2: 🐛 "$this->getAuthToken()" seems to not be used through $headers Active
- Status changed to Fixed
12 months ago 12:00pm 19 April 2024 - Issue was unassigned.
Automatically closed - issue fixed for 2 weeks with no activity.