Contrib.social

Unordered list not displayed with ordered list styling in preview

Open on Drupal.org →
Created on 18 April 2024, 2 months ago

Problem/Motivation

A particular combination of code results in an unordered list not being displayed with ordered list styling in the preview.

Steps to reproduce

1. Create a comment on an existing issue:

Okay, I don't want to mess up your Tugboat instance. The instance on 
            
              
              
              🐛
              navigation_theme() loads 'extension.list.module' for no purpose.
                Needs review
              
             doesn't seem to have Admin Toolbar.

However, the specific configuration I want to test is as follows:

<ol>
  <li>On /admin/modules, in addition to the Admin Tool bar, enable Admin Toolbar Extra Tools</li>
  <li>Click Install</li>
  <li>Expand Admin Toolbar Extra Tools</li>
  <li>Click Configure</li>
  <li>Check Enable/Disable local tasks display</li>
  <li>Click Save configuration</li>
  <li>Navigate to some existing content</li>
</ol>

Expected result: there is a local task menu, with the following sub-items:

<ul>
  <li>View</li>
  <li>Edit</li>
  <li>Delete</li>
  <li>Revisions</li>
</ul>

Presumably with Navigation also installed, the local task menu would be incorporated into the left side bar navigation.

If Admin Tool Bar isn't compatible with navigation, then I would expect there to be some other means by which I could incorporate such a menu and sub-menu into the navigation menu.

As a sidenote, I dislike the "local task" label as being jargon, and have separately filed 
            
              
              
              🐛
              "Local tasks" is hard to understand
                Active

2. Click Preview

Expected result: The words view, edit, delete, and revisions appear in an ordered list with bullets
Actual result: The words view, edit, delete, and revisions appear without any bullets

This happened while preparing comment number 8 🐛 Navigation module gets error when added on simplytest.me Active on 🐛 Navigation module gets error when added on simplytest.me Active .

3. Click Save

Expected and actual results: The words view, edit, delete, and revisions appear in an ordered list with bullets

Note: The issue does not recur if I attempt to edit the comment and preview that. It only occurs on the initial entry and preview.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

2.0

Component

User interface

Created by

🇺🇸United States Charles Belov San Francisco, CA, US

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Charles Belov
  • Comment 2 months ago →
    🇺🇸United States Charles Belov San Francisco, CA, US
  • Comment 2 months ago →
    🇺🇸United States Charles Belov San Francisco, CA, US

    Reapplying this comment to the current issue (which it does not apply to) to verify reproducibility and confirming that it happens here as well following the steps listed above in the current issue description:

    Okay, I don't want to mess up your Tugboat instance. The instance on 🐛 navigation_theme() loads 'extension.list.module' for no purpose. Needs review doesn't seem to have Admin Toolbar.

    However, the specific configuration I want to test is as follows:

    1. On /admin/modules, in addition to the Admin Tool bar, enable Admin Toolbar Extra Tools
    2. Click Install
    3. Expand Admin Toolbar Extra Tools
    4. Click Configure
    5. Check Enable/Disable local tasks display
    6. Click Save configuration
    7. Navigate to some existing content

    Expected result: there is a local task menu, with the following sub-items:

    • View
    • Edit
    • Delete
    • Revisions

    Presumably with Navigation also installed, the local task menu would be incorporated into the left side bar navigation.

    If Admin Tool Bar isn't compatible with navigation, then I would expect there to be some other means by which I could incorporate such a menu and sub-menu into the navigation menu.

    As a sidenote, I dislike the "local task" label as being jargon, and have separately filed 🐛 "Local tasks" is hard to understand Active

  • Comment 2 months ago →
    🇺🇸United States drumm NY, US

    This is a symptom of the default <ul> style being made for landing pages instead of for content.

    Ideally, in https://git.drupalcode.org/project/bluecheese/-/blob/7.x-2.x/sass/partia... most #content ul should be simplified to ul, and redundant styles throughout the theme removed. This would need a decent auditing of lists throughout the site, but would be a good simplification in the long run.

    Or, we may want to add a special case for this.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024