navigation_theme() loads 'extension.list.module' for no purpose.

Created on 17 April 2024, about 1 year ago
Updated 18 May 2024, 12 months ago

Problem/Motivation

path is no longer used at all in template. makes large service call in bad spot!

Steps to reproduce

see FN navigation_theme() in navigation.module

  $items['menu_region__footer'] = [
    'variables' => [
      'help' => NULL,
      'items' => [],
      'title' => NULL,
      'menu_name' => NULL,
      'path' => \Drupal::service('extension.list.module')->getPath('navigation'),
    ],
  ];

Proposed resolution

remove legacy var

Remaining tasks

User interface changes

none

API changes

none

Data model changes

none

🐛 Bug report
Status

Fixed

Version

10.3

Component
Navigation 

Last updated 3 days ago

No maintainer
Created by

🇨🇦Canada SKAUGHT

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @SKAUGHT
  • Status changed to Needs review about 1 year ago
  • Pipeline finished with Success
    about 1 year ago
    Total: 226s
    #149429
  • 🇪🇸Spain ckrina Barcelona

    Moving to Needs work after getting Navigation into core.

  • Status changed to Needs work about 1 year ago
  • First commit to issue fork.
  • Pipeline finished with Success
    about 1 year ago
    Total: 602s
    #158154
  • 🇫🇮Finland kekkis Pirkkala

    kekkis changed the visibility of the branch 3441615-navigationtheme-loads-extension.list.module to hidden.

  • Status changed to Needs review about 1 year ago
  • Status changed to RTBC about 1 year ago
  • 🇷🇸Serbia finnsky

    Tested and seems all works fine.

  • 🇫🇮Finland kekkis Pirkkala

    RTBC +1.

    Also checked at least that `path` does not appear anywhere in the templates as a variable. The only occurrence in menu templates of this theme hook refers to the twig function called path().

    $ grep -r 'path' --include=menu-region--footer.html.twig
    ./core/modules/navigation/templates/menu-region--footer.html.twig:          attributes: create_attribute({ 'href': path('help.main'), 'data-drupal-tooltip': 'Help'|t, 'data-drupal-tooltip-class': 'admin-toolbar__tooltip' }),
    
  • Status changed to Downport about 1 year ago
  • 🇬🇧United Kingdom catch

    Committed/pushed to 11.x, thanks!

    Moving to 10.3.x for backport assuming that the main navigation commit gets backported there too.

    • catch committed 10623874 on 11.x
      Issue #3441615 by SKAUGHT, mErilainen, kekkis: navigation_theme() loads...
    • catch committed 62f43ebc on 10.3.x
      Issue #3441615 by SKAUGHT, mErilainen, kekkis: navigation_theme() loads...
  • Status changed to Fixed about 1 year ago
    • catch committed 10623874 on 11.0.x
      Issue #3441615 by SKAUGHT, mErilainen, kekkis: navigation_theme() loads...
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Skipped
    8 months ago
    #287145
  • Pipeline finished with Success
    6 months ago
    Total: 276s
    #326141
  • Pipeline finished with Success
    6 months ago
    Total: 384s
    #329498
  • Pipeline finished with Success
    6 months ago
    Total: 342s
    #329512
  • Pipeline finished with Skipped
    6 months ago
    #330439
  • Pipeline finished with Success
    6 months ago
    Total: 163s
    #336728
  • Pipeline finished with Canceled
    5 months ago
    Total: 184s
    #356641
  • Pipeline finished with Canceled
    5 months ago
    Total: 167s
    #356643
  • Pipeline finished with Success
    5 months ago
    Total: 1524s
    #356645
  • Pipeline finished with Failed
    5 months ago
    Total: 658s
    #356662
  • Pipeline finished with Success
    4 months ago
    Total: 148s
    #392188
  • Pipeline finished with Success
    4 months ago
    Total: 152s
    #392191
  • Pipeline finished with Success
    19 days ago
    Total: 266s
    #479605
  • Pipeline finished with Success
    19 days ago
    Total: 383s
    #479631
  • Pipeline finished with Success
    19 days ago
    Total: 309s
    #479638
  • Pipeline finished with Failed
    19 days ago
    Total: 303s
    #479646
  • Pipeline finished with Success
    18 days ago
    Total: 396s
    #480223
  • Pipeline finished with Success
    18 days ago
    Total: 302s
    #480593
  • Pipeline finished with Success
    13 days ago
    Total: 298s
    #483900
  • Pipeline finished with Success
    13 days ago
    Total: 1092s
    #483972
  • Pipeline finished with Success
    13 days ago
    Total: 298s
    #484032
  • Pipeline finished with Success
    13 days ago
    Total: 323s
    #484191
Production build 0.71.5 2024