- Issue created by @charles belov
- π¨π¦Canada SKAUGHT
I might assume that because this module (only having a dev line) and is being prepared in process of π [No commit] Prepare for core inclusion Active that flaws in the current .info.yml are currently being tuned for this purpose.
- πΊπΈUnited States charles belov San Francisco, CA, US
That's unfortunate. I wanted to check whether there were any conflicts between the Navigation and Admin Toolbar modules.
- π¨π¦Canada SKAUGHT
I can tell you myself: simply, these 2 modules would not be compatible.
The goal of Navigation is to 100% toolbar, and currently does force the removal of 'toolbar' from 'page top'. there's not plan to align with admin_toolbars JS...etc In the background, Toolbar is still running if enabled, again Navigation bypasses final render.
- π¨π¦Canada SKAUGHT
PS: TUGBOAT
You should also look into Tugboat access through your d-org account! - π¨π¦Canada SKAUGHT
to validate that with both modules on: we see no Admin Toolbar. there are also no JS console errors -- everything looks clean. - πΊπΈUnited States charles belov San Francisco, CA, US
Okay, I don't want to mess up your Tugboat instance. The instance on π navigation_theme() loads 'extension.list.module' for no purpose. Needs review doesn't seem to have Admin Toolbar.
However, the specific configuration I want to test is as follows:
- On /admin/modules, in addition to the Admin Tool bar, enable Admin Toolbar Extra Tools
- Click Install
- Expand Admin Toolbar Extra Tools
- Click Configure
- Check Enable/Disable local tasks display
- Click Save configuration
- Navigate to some existing content
Expected result: there is a local task menu, with the following sub-items:
- View
- Edit
- Delete
- Revisions
Presumably with Navigation also installed, the local task menu would be incorporated into the left side bar navigation.
If Admin Tool Bar isn't compatible with navigation, then I would expect there to be some other means by which I could incorporate such a menu and sub-menu into the navigation menu.
As a sidenote, I dislike the "local task" label as being jargon, and have separately filed π "Local tasks" is hard to understand Active
- πΊπΈUnited States charles belov San Francisco, CA, US
I have filed π Ensure Local task functionality provided by Admin toolbar extra can be implemented in Navigation Active .
- π¨π¦Canada SKAUGHT
@Charles Belov. Welcome!
I understand the flood of concerns when discovering this work! i've only gotten involved in the last few weeks myself.I posted this on 3441903 as well: this will help find the 'current plan' for Navigation!
https://www.drupal.org/project/issues/navigation?text=%5Bplan%5D&status=... βOn Drupal Slack you'll be able to the 'Admin UI' channel -- this is where the Navigation Project/team is to be found. weekly meetings are Wednesdays (timezones) if you want to get involved this way!
---
Sorry that simplytest.me is blocking for you this way!
- πͺπΈSpain ckrina Barcelona
We've been in contact with the Admin Toolbar folks in the past so they can expand and implement functionalities on the Navigation and coordinate on that, but we haven't had time to sync again after the Beta release just last week. Since Admin Toolbar works on top of the old Toolbar, don't expect its features on the new navigation yet. We (navigation team) will help as much as we can but the updates the Admin Toolbar module will need will be important, so please be aware that it won't be a matter of a few days. :)
The initial conversations were promising and features like the Devel menu or the Search were a few of the ones Admin Toolbar could possibly add a lot of value. We're also Drupal devs that use Admin Toolbar on every project, so it's in our own interest to coordinate to work together, but we're just focused on getting this in core in the next days.
- Status changed to Closed: works as designed
8 months ago 11:47am 29 April 2024 - π¨π¦Canada SKAUGHT
Navigation has been accepted to Drupal 11 dev line now. I'll close this as is no longer valid. thanks!