Forked DocParser incorrectly parses ::class notations

Even though this is on the way out, we will need to support it through the 11.x lifecycle, so there's no harm in improving it in my opinion

Ran test-only feature

1) Drupal\Tests\Component\Annotation\Doctrine\DocParserTest::testSupportClassConstants with data set #1 ('@AnnotationWithConstants(\Sim...class)', 'SimpleXMLElement')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'SimpleXMLElement'
+'\SimpleXMLElement'
/builds/issue/drupal-3440170/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:94
/builds/issue/drupal-3440170/core/tests/Drupal/Tests/Component/Annotation/Doctrine/DocParserTest.php:881
/builds/issue/drupal-3440170/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
/builds/issue/drupal-3440170/vendor/phpunit/phpunit/src/Framework/TestSuite.php:684
/builds/issue/drupal-3440170/vendor/phpunit/phpunit/src/Framework/TestSuite.php:684
/builds/issue/drupal-3440170/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651
/builds/issue/drupal-3440170/vendor/phpunit/phpunit/src/TextUI/Command.php:144
/builds/issue/drupal-3440170/vendor/phpunit/phpunit/src/TextUI/Command.php:97
FAILURES!
Tests: 227, Assertions: 481, Failures: 1.

So coverage for change is there.

Left a comment a comment though, that just may not be me understanding

I see other examples of the space in the file. Don't fully understand but does seem to address the issue.

PHPCS is disabled here because this is a copy of Doctrine code with different standards, but we should still conform to Doctrine formatting by using 4-space indents.

I updated the MR to use 4 space indenting on all the changes.

In the future, I would like to have a situation where we don't spend time on formatting issues on forked code that is on the way out.

Rebased for the failing kernel failures. Believe the javascript to be unrelated.

Don't particularly like the code... str_starts_with() exists in our minimum PHP but it's a copy of upstream so whatevs... let's march forward to the time we don't have to maintain this.

Committed and pushed f1f27ff7f3 to 11.x and 3adb7e2297 to 10.3.x. Thanks!
Committed 5d783fb and pushed to 10.2.x. Thanks!

Out of my own curiosity does ! having a space mean anything?

No - ! $something and !$something mean the same thing, it's just stylistic preference.

quietone → closed merge request !7446

Thanks for such a fast resolution of the problem! \o/

let's march forward to the time we don't have to maintain this.

+1

Automatically closed - issue fixed for 2 weeks with no activity.