Remove hardcoding #group for the status field

pradhumanjain2311 → made their first commit to this issue’s fork.

Can you please test this with what we're working on in ✨ Move Action buttons to sticky header Fixed ?

tested it on the dev version with the suggested changes from ✨ Move Action buttons to sticky header Fixed
nothing has changed (I also noticed that the sidebar switch is hidden in the ellipsis, it seems it shouldn't be like that)

@maks

tested it on the dev version with the suggested changes from #3356717: Move Action buttons to sticky header
nothing has changed

Okay thanks for verifying

(I also noticed that the sidebar switch is hidden in the ellipsis, it seems it shouldn't be like that)

That is intentional

We have experienced this same issue in farmOS for some time where the entity status field is not a checkbox. I solved it in other ways (our own version of GinContentForm so to say) but agree with the proposed fix to only move the status when it is a checkbox.

Furthermore, I'm running into this issue on *simple forms* (not entity forms, not gin content forms) after ✨ Move Action buttons to sticky header Fixed . With this change and status field in a form is moved out of the form to the actions area. Not only is this unexpected, but it also results in this status field not being included in the form submission (I believe because the status is moved without the additional template changes that content forms receive?)

I think the fix is two parts:
1. Only move the status field on gin content forms
2. Only move the status field when it is a checkbox

I've opened a new MR with these changes. It also includes some changes to simplify GinContentFormHelper logic and also likely increase performance (don't invoke thegin_content_form_routes hook multiple times!!!)

I've rebased this MR onto the latest 8.x-3.x, there was only one minor conflict with the last commit with this MR. Still need a review on this

Not able to Replicate this issue on my local.