- Issue created by @Devendra Mishra
- Assigned to abhishek_virasat
- Issue was unassigned.
- Merge request !21Issue #3281812 by pjotr.savitski, Daniel Kulbe, sourabhjain, apaderno,... → (Open) created by abhishek_virasat
- Status changed to RTBC
7 months ago 7:09am 15 April 2024 - 🇮🇳India abhishek_virasat
above patch fixed the issue, also I created MR , moving RTBC++.
- 🇨🇦Canada ryanrobinson_wlu
Patch also worked for me.
Minor note on the issue description: this started with PHP 8.2, not just 8.3. I found it when I tried updating from 8.1 to 8.2.
- 🇨🇦Canada ryanrobinson_wlu
Update: I got three more of them after creating a new H5P node (a Multiple Choice quiz, but I don't know if that matters).
Deprecated function: Creation of dynamic property H5PValidator::$h5pCV is deprecated in H5PValidator->__construct() (line 743 of /opt/drupal/vendor/h5p/h5p-core/h5p.classes.php). Deprecated function: Creation of dynamic property H5peditor::$content is deprecated in H5peditor->processParameters() (line 158 of /opt/drupal/vendor/h5p/h5p-editor/h5peditor.class.php). Deprecated function: Creation of dynamic property H5PContentValidator::$allowedStyles is deprecated in H5PContentValidator->filter_xss() (line 4198 of /opt/drupal/vendor/h5p/h5p-core/h5p.classes.php). - Status changed to Closed: outdated
7 months ago 12:16am 9 May 2024 - 🇨🇦Canada shaundychko
These deprecations are fixed in the core h5p library version 1.26. Here's the github issue: https://github.com/h5p/h5p-php-library/pull/148. After sorting out how to update the core library used in this module (see 🐛 Support h5p/h5p-core:1.26 and h5p/h5p-editor:1.25 Needs work ), this issue will be fixed.
- Status changed to Active
7 months ago 12:17am 9 May 2024 - 🇺🇸United States SocialNicheGuru
📌 Allow update to H5P editor/core 1.25 Fixed was committed. But Version 1.25 does not solve the issue.
- 🇨🇦Canada ryanrobinson_wlu
I've updated the patch to also cover a couple of the deprecations I see when I create a new node with an H5P object. It's the same idea as the previous patch, just a couple more of them.
These are just the ones that are in the h5p-core. I'm still trying to figure out how to write a patch for h5p-editor which is still giving me another deprecation warning when I create a new object.
- 🇨🇦Canada ryanrobinson_wlu
Here's a patch for the h5p-editor file's deprecation I was getting.
This one was a bit weird. I found the git repo for h5p-editor here: https://github.com/h5p/h5p-editor-php-library. In that master branch, the fix was already in place.
But the Drupal module is locked to an older version. I tried the patch in https://www.drupal.org/project/h5p/issues/3411479 📌 Allow update to H5P editor/core 1.25 Fixed to allow a higher version of h5p-editor. The patch applied, but it did not seem to do anything to update my h5p-editor version.
So then I went ahead with cloning from 1.24.4 and creating a patch based on that.