Contrib.social

Add validation constraints to system.image and system.image.gd

Open on Drupal.org →
Created on 10 April 2024, about 1 year ago
Updated 28 April 2024, about 1 year ago

Problem/Motivation

system.image and system.image.gd each has 1 property path that are not yet validatable:

./vendor/bin/drush config:inspect --filter-keys=system.image,system.image.gd --detail --list-constraints
➜  🤖 Analyzing…

 Legend for Data: 
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 -------------------------------------------- --------- ------------- ------ ------------------------------------------ 
  Key                                          Status    Validatable   Data   Validation constraints                    
 -------------------------------------------- --------- ------------- ------ ------------------------------------------ 
  system.image                                 Correct   75%           ✅❓   ValidKeys: '<infer>'                      
   system.image:                               Correct   Validatable   ✅✅   ValidKeys: '<infer>'                      
   system.image:_core                          Correct   Validatable   ✅✅   ValidKeys:                                
                                                                                - default_config_hash                   
   system.image:_core.default_config_hash      Correct   Validatable   ✅✅   NotNull: {  }                             
                                                                              Regex: '/^[a-zA-Z0-9\-_]+$/'              
                                                                              Length: 43                                
                                                                              ↣ PrimitiveType: {  }                     
   system.image:toolkit                        Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here  
  system.image.gd                              Correct   75%           ✅❓   ValidKeys: '<infer>'                      
   system.image.gd:                            Correct   Validatable   ✅✅   ValidKeys: '<infer>'                      
   system.image.gd:_core                       Correct   Validatable   ✅✅   ValidKeys:                                
                                                                                - default_config_hash                   
   system.image.gd:_core.default_config_hash   Correct   Validatable   ✅✅   NotNull: {  }                             
                                                                              Regex: '/^[a-zA-Z0-9\-_]+$/'              
                                                                              Length: 43                                
                                                                              ↣ PrimitiveType: {  }                     
   system.image.gd:jpeg_quality                Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here  
 -------------------------------------------- --------- ------------- ------ ------------------------------------------

Steps to reproduce

  1. Get a local git clone of Drupal core 10.3.x.
  2. composer require drupal/config_inspector — or manually install https://www.drupal.org/project/config_inspector/releases/2.1.5 → or newer (which supports Drupal 11!)
  3. composer require drush/drush
  4. ./vendor/bin/drush config:inspect --filter-keys=system.image,system.image.gd --detail --list-constraints

Proposed resolution

Add validation constraints to:

  1. system.image:toolkit
  2. system.image.gd:jpeg_quality

For examples, search *.schema.yml files for the string constraints: 😊

Reach out to @borisson_ or @wimleers in the #distributions-and-recipes.

Remaining tasks

User interface changes

None.

API changes

Data model changes

More validation 🚀

Release notes snippet

None.

📌 Task
Status

Fixed

Version

10.3 ✨

Component
System  →

Last updated 22 minutes ago

No maintainer
Created by

🇮🇳India narendraR Jaipur, India

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024