- Issue created by @narendraR
- First commit to issue fork.
- Status changed to Needs review
5 months ago 3:51pm 11 April 2024 - ๐บ๐ธUnited States phenaproxima Massachusetts
This is probably ready to go...
- Status changed to RTBC
5 months ago 4:08pm 11 April 2024 - ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
No hesitations โ this looks perfect ๐
- Status changed to Needs work
5 months ago 4:09pm 11 April 2024 - ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
โฆ except a single test (
ToolkitSetupFormTest
) just failed ๐ ๐ - Status changed to Needs review
5 months ago 4:11pm 11 April 2024 - ๐บ๐ธUnited States phenaproxima Massachusetts
Ugh, gotta work around the langcode thing.
- Status changed to RTBC
5 months ago 4:29pm 11 April 2024 - Status changed to Postponed
5 months ago 9:51pm 11 April 2024 - ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
๐ Require `langcode: โฆ` only for simple config that contains translatable values Active is RTBC so let's postpone on that so we don't need the todo.
- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
- Status changed to Needs work
5 months ago 7:05am 14 April 2024 - Status changed to Needs review
5 months ago 10:55am 14 April 2024 - Status changed to RTBC
5 months ago 11:39am 14 April 2024 - ๐บ๐ธUnited States phenaproxima Massachusetts
Tests passing and all I did was remove the workarounds for langcode, so restoring the previous RTBC.
- Status changed to Needs work
5 months ago 11:40am 14 April 2024 The Needs Review Queue Bot โ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- Status changed to RTBC
5 months ago 11:43am 14 April 2024 - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
Committed and pushed 68628ccef2 to 11.x and 18cbe89f06 to 10.3.x. Thanks!
-
alexpott โ
committed 18cbe89f on 10.3.x
Issue #3439932 by phenaproxima, narendraR, Wim Leers, larowlan: Add...
-
alexpott โ
committed 18cbe89f on 10.3.x
- Status changed to Fixed
5 months ago 5:45pm 14 April 2024 -
alexpott โ
committed 68628cce on 11.x
Issue #3439932 by phenaproxima, narendraR, Wim Leers, larowlan: Add...
-
alexpott โ
committed 68628cce on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.