- Issue created by @vensires
- First commit to issue fork.
- Merge request !7575Issue #3439925: Fix Core tests that rely on UID1's super user behavior β (Open) created by simonbaese
- Status changed to Needs review
7 months ago 10:15am 18 April 2024 - π©πͺGermany simonbaese Berlin
After aligning with @kristiaanvandeneynde the
RenderCacheTest
should be removed entirely. See related issue π UserRolesCacheContext can lead to poisoned cache returns for user 1 Active . - Status changed to Needs work
7 months ago 1:32pm 18 April 2024 - πΊπΈUnited States smustgrave
Removing the tests appear to be scope creep though. Believe the test removal should be done in the issue you mentioned.
- Status changed to Postponed
7 months ago 1:45pm 18 April 2024 - π©πͺGermany simonbaese Berlin
Then the mentioned issue should be solved first, because we can not fix this issue if not removing the test.
- πΊπΈUnited States smustgrave
So actually could just leave that one test as is (revert in MR).
Put a todo in it to π UserRolesCacheContext can lead to poisoned cache returns for user 1 Active that it will be removed
Updated π UserRolesCacheContext can lead to poisoned cache returns for user 1 Active to make sure they remove the test there.Then the other 2 can move forward.
- Status changed to Needs review
7 months ago 5:05pm 18 April 2024 - π©πͺGermany simonbaese Berlin
@smustgrave I reverted the deletion of the
RenderCacheTest
. Can you please make respective comments and add todos in the other issues. I am having a hard time understanding your last comment. - Status changed to RTBC
7 months ago 2:06pm 19 April 2024 - πΊπΈUnited States smustgrave
Added todo to the test we aren't updating here and updated IS in π UserRolesCacheContext can lead to poisoned cache returns for user 1 Active
- Status changed to Fixed
7 months ago 4:05pm 20 April 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed cbad32ab34 to 11.x and 097371801c to 10.3.x. Thanks!
-
alexpott β
committed 09737180 on 10.3.x
Issue #3439925 by simonbaese, smustgrave, vensires: Fix Core tests that...
-
alexpott β
committed 09737180 on 10.3.x
-
alexpott β
committed cbad32ab on 11.x
Issue #3439925 by simonbaese, smustgrave, vensires: Fix Core tests that...
-
alexpott β
committed cbad32ab on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.