Contrib.social

Fix Migrate Drupal UI tests that rely on UID1's super user behavior

Open on Drupal.org →
Created on 10 April 2024, 9 months ago
Updated 9 May 2024, 8 months ago

Problem/Motivation

In 📌 Add a container parameter that can remove the special behavior of UID#1 Fixed an approach was taken where we can simply flag tests that are failing if we turn off user 1's super user powers, so that they can be taken care of in a followup. This issue is to collect all of these followups.

The goal is to have no tests in Drupal core that rely on UID1's special privileges so that we:

  1. Know these tests are correctly assigning the necessary permissions to run
  2. Can turn off the super user access policy in D11, knowing it won't break core
  3. Can remove the super user access policy in D12, providing an admin account recovery tool to replace it

Steps to reproduce

Go into any of the tests flagged with:

  /**
   * {@inheritdoc}
   *
   * @todo Remove and fix test to not rely on super user.
   * @see https://www.drupal.org/project/drupal/issues/3437620
   */

And:

  1. Remove the code below that sets the usesSuperUserAccessPolicy to TRUE.
  2. Run the test to see which test methods are failing

Proposed resolution

Assign the right permissions to make the test go green without the super user access policy. Those few tests that specifically test said policy can obviously stay, but will be removed along with the policy in D12.

Remaining tasks

  • core/modules/migrate_drupal_ui/tests/src/
    • Functional/MigrateControllerTest.php
📌 Task
Status

Closed: won't fix

Version

11.0 🔥

Component
Migration  →

Last updated about 13 hours ago

Created by

🇬🇷Greece vensires

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @vensires
  • Comment 9 months ago →
    🇳🇿New Zealand quietone

    Migrate UI was designed to be only available for the administrator, uid = 1. And there is no special permission for it. See '\Drupal\migrate_drupal_ui\MigrateAccessCheck::checkAccess(). And this year an issue has been opened to change that.

  • First commit to issue fork.
  • Merge request !7664introduced new permission and removed hard coding → (Closed) created by sukr_s
  • Pipeline finished with Failed
    8 months ago
    Total: 1554s
    #153971
  • Pipeline finished with Failed
    8 months ago
    Total: 497s
    #154002
  • Comment 8 months ago →
    🇮🇳India sukr_s

    Tests are failing since the batch fails to load due to sudden change in CSRF token. Not sure though why the token changes during the batch process

  • Pipeline finished with Failed
    8 months ago
    Total: 1544s
    #162248
  • Comment 8 months ago →
    System Message
  • Comment 8 months ago →
    🇺🇸United States mikelutz Michigan, USA

    I think we can close this. Migrate Drupal UI is a special case where we really do need to check against uid 1. D7 sites being migrated from effectively have a super user access policy, so it doesn't make sense to have it disabled in d11 in the context of migrate.

    With migrate Drupal slated for deprecation and removal by d12, this should be fine to leave.

  • Status changed to Closed: won't fix 8 months ago
  • Comment 8 months ago →
    🇺🇸United States mikelutz Michigan, USA

    Talked with @catch, we are going to leave these alone as they will be gone before d12 anyway.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024