- Issue created by @polynya
- Assigned to abhishek_virasat
- Status changed to Needs review
9 months ago 12:08pm 4 April 2024 - Issue was unassigned.
- 🇮🇳India abhishek_virasat
applied #3 patch. issue is fixed now. and created MR.
- 🇬🇧United Kingdom polynya
Thanks abhishek_gupta1. My patch also fixed the settings form.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
In what scenario would this be missing
If a module can't rely on the presence of config it installed something is wrong
- 🇬🇧United Kingdom polynya
The settings form has been added recently. When the form is saved with no entities selected then the configuration is deleted by:
$config->clear('enabled_entity_types');
This should be:
$config->set('enabled_entity_types', []);
- Status changed to Needs work
9 months ago 7:56pm 5 April 2024 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Yes you're correct.
Can we get a post update hook to set NULL to [] in the config and remove the null handling?
We should fix broken config instead of babysitting it.Thank you!