Add validation constraints to update.settings

This is going to need an update path to convert an empty notification.emails array to NULL.

pradhumanjain2311 → made their first commit to this issue’s fork.

Looks pretty good; a few minor things, but otherwise it just needs an update path test.

srishtiiee → changed the visibility of the branch 3437319-add-validation-constraints to hidden.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

95% ready:

1. Spotted one key-value pair that seems to be missing validation?
2. AFAICT we'd actually be able to avoid an update path here? 😇😄

Believe the MR should be pointing to 11.x right?

Also won't we need an upgrade path for the settings changes

srishtiiee → changed the visibility of the branch 3437319-add-validation-constraints to active.

I don't think we need an upgrade path for the changes we've done here. The config change that required one has been reverted.

One question, but otherwise that looks RTBC to me. I agree that there's no clear need for an update path.

One non-commit-blocking thought/observation … but I think this is ready :)

Committed and pushed d7bcfdf6d7 to 11.x and 3ade5afd02 to 10.3.x. Thanks!