Add validation constraints to update.settings

Open on Drupal.org →

Created on 1 April 2024, 3 months ago

Updated 29 April 2024, about 2 months ago

Problem/Motivation

Update module has 5 property paths that are not yet validatable.

vendor/bin/drush config:inspect --filter-keys=update.settings --detail --list-constraints
➜  🤖 Analyzing…

 Legend for Data: 
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 -------------------------------------------- --------- ------------- ------ --------------------------------------------------- 
  Key                                          Status    Validatable   Data   Validation constraints                             
 -------------------------------------------- --------- ------------- ------ --------------------------------------------------- 
  update.settings                              Correct   64%           ✅❓   ValidKeys: '<infer>'                               
   update.settings:                            Correct   Validatable   ✅✅   ValidKeys: '<infer>'                               
   update.settings:_core                       Correct   Validatable   ✅✅   ValidKeys:                                         
                                                                                - default_config_hash                            
   update.settings:_core.default_config_hash   Correct   Validatable   ✅✅   NotNull: {  }                                      
                                                                              Regex: '/^[a-zA-Z0-9\-_]+$/'                       
                                                                              Length: 43                                         
                                                                              ↣ PrimitiveType: {  }                              
   update.settings:check                       Correct   Validatable   ✅✅   ValidKeys: '<infer>'                               
   update.settings:check.disabled_extensions   Correct   Validatable   ✅✅   ↣ PrimitiveType: {  }                              
   update.settings:check.interval_days         Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here          
   update.settings:fetch                       Correct   Validatable   ✅✅   ValidKeys: '<infer>'                               
   update.settings:fetch.max_attempts          Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here          
   update.settings:fetch.timeout               Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here          
   update.settings:fetch.url                   Correct   Validatable   ✅✅   ↣ PrimitiveType: {  }                              
   update.settings:notification                Correct   Validatable   ✅✅   ValidKeys: '<infer>'                               
   update.settings:notification.emails         Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here          
   update.settings:notification.emails.0       Correct   Validatable   ✅✅   Email:                                             
                                                                                message: '%value is not a valid email address.'  
                                                                              ↣ PrimitiveType: {  }                              
   update.settings:notification.threshold      Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here          
 -------------------------------------------- --------- ------------- ------ ---------------------------------------------------

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task

Status

Fixed

Version

10.3 ✨

Component

Last updated 3 days ago

Maintained by
🇺🇸United States @tedbow
🇺🇸United States @dww

Created by

🇮🇳India srishtiiee

Live updates comments and jobs are added and updated live.

Configuration schema

validation

no-needs-review-bot

Sign in to follow issues

Merge Requests

!7301Add validation constraints to update.settings
Open
🇮🇳India srishtiiee
updated about 2 months ago
!7514Add validation constraints to update.settings
Open
🇮🇳India srishtiiee
updated about 2 months ago

Comments & Activities

Issue created by @srishtiiee
Merge request !73013437319: Add validation constraints to update.settings → (Open) created by srishtiiee
Pipeline finished with Failed
3 months ago
Total: 526s
#136084
Pipeline finished with Failed
3 months ago
Total: 496s
#136116
Comment 3 months ago →
🇺🇸United States phenaproxima Massachusetts
This is going to need an update path to convert an empty notification.emails array to NULL.
Status changed to Needs work 3 months ago3:43pm 8 April 2024
Comment 3 months ago →
🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Comment 3 months ago →
🇮🇳India pradhumanjainOSL
pradhumanjain2311 → made their first commit to this issue’s fork.
Pipeline finished with Failed
3 months ago
Total: 497s
#140953
Pipeline finished with Failed
3 months ago
Total: 674s
#141708
Comment 3 months ago →
🇺🇸United States phenaproxima Massachusetts
Looks pretty good; a few minor things, but otherwise it just needs an update path test.
Pipeline finished with Failed
3 months ago
Total: 527s
#142617
Pipeline finished with Failed
2 months ago
Total: 552s
#147115
Comment 2 months ago →
🇮🇳India srishtiiee
Pipeline finished with Failed
2 months ago
Total: 3915s
#147617
Merge request !7514Resolve #3437319 "Add validation constraints to update.settings" → (Open) created by srishtiiee
Comment 2 months ago →
🇮🇳India srishtiiee
srishtiiee → changed the visibility of the branch 3437319-add-validation-constraints to hidden.
Pipeline finished with Failed
2 months ago
Total: 2874s
#147680
Pipeline finished with Canceled
2 months ago
Total: 223s
#148840
Pipeline finished with Failed
2 months ago
Total: 1024s
#148849
First commit to issue fork.
Pipeline finished with Failed
2 months ago
Total: 990s
#149434
Comment 2 months ago →
🇮🇳India narendraR Jaipur, India
Pipeline finished with Success
2 months ago
Total: 960s
#149966
Pipeline finished with Canceled
2 months ago
Total: 211s
#150306
Pipeline finished with Success
2 months ago
#150309
Status changed to Needs review 2 months ago3:56pm 18 April 2024
Comment 2 months ago →
🇮🇳India srishtiiee
Status changed to Needs work 2 months ago4:27pm 18 April 2024
Comment 2 months ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Status changed to Needs review 2 months ago4:40pm 18 April 2024
Comment 2 months ago →
🇺🇸United States phenaproxima Massachusetts
Status changed to Needs work 2 months ago8:42am 19 April 2024
Comment 2 months ago →
🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
95% ready:

Spotted one key-value pair that seems to be missing validation?

AFAICT we'd actually be able to avoid an update path here? 😇😄
Pipeline finished with Success
2 months ago
Total: 987s
#153048
Status changed to Needs review 2 months ago7:40am 22 April 2024
Comment 2 months ago →
🇮🇳India srishtiiee
Status changed to Needs work 2 months ago1:44pm 22 April 2024
Comment 2 months ago →
🇺🇸United States smustgrave
Believe the MR should be pointing to 11.x right?

Also won't we need an upgrade path for the settings changes
Pipeline finished with Success
2 months ago
Total: 483s
#156345
Comment 2 months ago →
🇮🇳India srishtiiee
srishtiiee → changed the visibility of the branch 3437319-add-validation-constraints to active.
Status changed to Needs review 2 months ago6:48am 26 April 2024
Comment 2 months ago →
🇮🇳India srishtiiee
I don't think we need an upgrade path for the changes we've done here. The config change that required one has been reverted.
Comment 2 months ago →
🇺🇸United States phenaproxima Massachusetts
One question, but otherwise that looks RTBC to me. I agree that there's no clear need for an update path.
Pipeline finished with Success
about 2 months ago
#159475
Status changed to RTBC about 2 months ago10:12am 29 April 2024
Comment about 2 months ago →
🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
One non-commit-blocking thought/observation … but I think this is ready :)
Comment about 2 months ago →
System Message

alexpott → committed 3ade5afd on 10.3.x
Issue #3437319 by srishtiiee, narendraR, pradhumanjain2311, phenaproxima...
Comment about 2 months ago →
System Message

alexpott → committed d7bcfdf6 on 11.x
Issue #3437319 by srishtiiee, narendraR, pradhumanjain2311, phenaproxima...
Status changed to Fixed about 2 months ago11:50pm 29 April 2024
Comment about 2 months ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed d7bcfdf6d7 to 11.x and 3ade5afd02 to 10.3.x. Thanks!

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024