CKEditor 5 table cell vertical align "middle" doesn't work

According CKEditor 5 library

The table cell vertical alignment

The following values, corresponding to the vertical-align CSS attribute, are allowed:
'top'
'bottom'
The 'middle' value is the default one so there is no need to set it.

for reference please check here https://ckeditor.com/docs/ckeditor5/latest/api/module_table_tablecellpro...

I have checked it with Olivero which has

:is(.forum table,.text-content table,.views-table,.draggable-table) td, :is(.forum table,.text-content table,.views-table,.draggable-table) th {
    padding-block: var(--sp1);
    padding-inline-start: 0;
    padding-inline-end: var(--sp1);
    vertical-align: top;
}

that's why on entity view data shows on top, if you check with another theme i.e. Claro it works fine so workaround can be override css in your theme.

Moving to correct version - we fix things in 11.x first and then backport as necessary / possible.

@sheetal-wish

Yes, looks like Olivero bug

Moving to active for the fix.

Not sure possible to provide any kind of tests but those would be needed if so.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

My only concern is this could break existing sites if they are using olivero

Yes, I understand. We can commit only in 11.x. Upgrade from 10 to 11 will require reading documentation and changes any way

Hi
I've tested MR !7317 on Drupal 10. It looks fine and the patch applied successfully...
After applying the patch, it shows that the table cells are getting properly vertically center aligned!

RTBC++

Attaching the before and after screenshots for reference

We don't promise backward compatibility in Olivero:

# This theme is marked as @internal. It is intended to evolve and change over
# minor releases.
# As the UI of Drupal improves between minor versions, the markup and assets in
# the Olivero theme will change. The Olivero theme is not backwards compatible

I think this is fine to fix in 10.3.0, but we should probably keep it as-is in 10.2.x to avoid surprises for anyone who is using it.

nod_ → closed merge request !7317

Committed f79817a and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.