- Issue created by @bronzehedwick
- 🇮🇳India ahsannazir
IMO it should toggle either on hover or on click. If the popover is opened on hover then why we need click to toggle show/hide the same popover. Can someone look into this and confirm that the current behavior implemented is what we want
- 🇺🇸United States bronzehedwick New York
On mobile the behavior only toggles on click, so it's possible the click events are "leaking" into desktop.
- Assigned to bronzehedwick
- Merge request !220Issue #3436873: Fix expanded popovers staying visible after click → (Open) created by bronzehedwick
- 🇺🇸United States bronzehedwick New York
I think I've figured this one out, and have a solution in an MR. I agree it seems like an unintended side effect that both hover and click toggle the menu on large screens. This is caused by two issues.
- Hovers are handled only on small screens, while clicks are handled on all screen sizes.
- Keeping the menu visible is done on
:focus
, not:focus-visible
, so is triggered by a click.
I'd love to hear if anyone has a different strategy or thoughts around this.
Thanks!
- Issue was unassigned.
- Status changed to Needs review
9 months ago 8:27pm 1 April 2024 - 🇮🇳India ahsannazir
Thanks @bronzehedwick. I think now the toolbar popover is behaving as it should and the provided solution looks good to me.
- 🇮🇳India Kanchan Bhogade
Hi,
I've tested MR !220 on Drupal 11.x
the patch applied successfully...After the patch, Popover is working as expected and looks good to me.
Adding files for the references
RTBC+1
Keeping "Needs review" for code verification
- Status changed to Postponed
9 months ago 5:08pm 2 April 2024 - 🇪🇸Spain ckrina Barcelona
Based on Slack conversation postponing this until 🐛 Drawer closes when moving from the opening item to "popover" Needs review gets in. Let's see if this is still needed when that gets in.
- Status changed to Fixed
9 months ago 12:07pm 3 April 2024 - 🇪🇸Spain ckrina Barcelona
This has been fixed in 🐛 Drawer closes when moving from the opening item to "popover" Needs review . Closing as fixed per the work done here :)
Automatically closed - issue fixed for 2 weeks with no activity.