Fix the issues reported by phpcs

FILE: /var/www/html/drupal-contri-d10/modules/contrib/seeds_layouts/src/SeedsLayoutsManager.php ------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------ 13 | WARNING | The class short comment should describe what the class does and not simply repeat the class name 50 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 175 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/drupal-contri-d10/modules/contrib/seeds_layouts/src/Form/FrameworkImportForm.php ----------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 13 | WARNING | The class short comment should describe what the class does and not simply repeat the class name ----------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/seeds_layouts/src/Form/SeedsLayoutsConfigForm.php ------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------- 56 | ERROR | Parameter $form_builder is not described in comment 56 | ERROR | Parameter $uuid is not described in comment 85 | ERROR | Doc comment short description must start with a capital letter ------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/seeds_layouts/src/Form/ColumnsForm.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 7 ERRORS AND 9 WARNINGS AFFECTING 14 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 16 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 47 | ERROR | [ ] Parameter $form_builder is not described in comment 47 | ERROR | [ ] Parameter $uuid is not described in comment 54 | ERROR | [ ] Doc comment for parameter $column_field_manager does not match actual variable name $uuid 74 | ERROR | [ ] Doc comment short description must start with a capital letter 160 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 161 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 252 | ERROR | [x] Expected 1 space after IF keyword; 0 found 252 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 261 | ERROR | [ ] Description for the @return value is missing 279 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 286 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 294 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 309 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 318 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 327 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/seeds_layouts/src/Plugin/SeedsLayout.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 96 | ERROR | Doc comment short description must start with a capital letter 232 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 232 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 241 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 309 | ERROR | The array declaration extends to column 159 (the limit is 120). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/drupal-contri-d10/modules/contrib/seeds_layouts/src/Plugin/LayoutField/HideField.php -------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES -------------------------------------------------------------------------------------------------------- 21 | ERROR | [x] Expected 1 blank line before function; 0 found 46 | ERROR | [ ] Doc comment short description must start with a capital letter 55 | ERROR | [x] Expected 1 blank line after function; 0 found 56 | ERROR | [x] The closing brace for the class must have an empty line before it -------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/seeds_layouts/src/Plugin/LayoutField/SelectField.php ----------------------------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AND 2 WARNINGS AFFECTING 8 LINES ----------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Plugin\ContainerFactoryPluginInterface. 29 | ERROR | [ ] Doc comment short description must start with a capital letter 37 | ERROR | [ ] Doc comment short description must start with a capital letter 49 | ERROR | [ ] Doc comment short description must start with a capital letter 58 | ERROR | [ ] Doc comment short description must start with a capital letter 74 | ERROR | [ ] Doc comment short description must start with a capital letter 80 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 82 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/seeds_layouts/src/Plugin/LayoutField/CheckboxField.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 19 | ERROR | Doc comment short description must start with a capital letter 33 | ERROR | Doc comment short description must start with a capital letter 45 | ERROR | Doc comment short description must start with a capital letter 51 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/seeds_layouts/src/Plugin/LayoutField/BackgroundImageField.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 10 ERRORS AND 4 WARNINGS AFFECTING 14 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 35 | ERROR | [ ] Missing parameter type 37 | ERROR | [ ] Missing parameter type 51 | ERROR | [ ] Doc comment short description must start with a capital letter 93 | ERROR | [ ] Doc comment is empty 101 | ERROR | [ ] Doc comment short description must start with a capital letter 106 | ERROR | [x] Use null coalesce operator instead of ternary operator. 113 | ERROR | [ ] Doc comment short description must start with a capital letter 126 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 136 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 142 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 150 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters 152 | ERROR | [x] Additional blank lines found at end of doc comment 163 | ERROR | [x] Data types in @param tags need to be fully namespaced 166 | ERROR | [ ] Description for the @return value is missing ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/seeds_layouts/src/Plugin/LayoutField/WrapBlocksField.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 5 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 22 | ERROR | [x] Expected 1 blank line before function; 0 found 77 | ERROR | [ ] Doc comment short description must start with a capital letter 82 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 82 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use "" quotes instead 97 | ERROR | [x] Expected 1 blank line after function; 0 found 98 | ERROR | [x] The closing brace for the class must have an empty line before it --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/seeds_layouts/src/Plugin/LayoutField/WrapField.php -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 13 ERRORS AND 9 WARNINGS AFFECTING 19 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 22 | ERROR | [x] Expected 1 blank line before function; 0 found 34 | ERROR | [x] Doc comment short description must end with a full stop 37 | ERROR | [x] Parameter comment must end with a full stop 39 | ERROR | [ ] Description for the @return value is missing 59 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters 60 | WARNING | [ ] Line exceeds 80 characters; contains 117 characters 60 | WARNING | [x] 'TODO: Find a way to add the wrapper inside the layout builder manage page without affecting drag-and-drop.' should match the format '@todo Fix problem X here.' 70 | ERROR | [ ] The array declaration extends to column 129 (the limit is 120). The array content should be split up over multiple lines 70 | ERROR | [ ] The array declaration extends to column 128 (the limit is 120). The array content should be split up over multiple lines 73 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters 98 | ERROR | [ ] Doc comment short description must start with a capital letter 103 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 103 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use "" quotes instead 115 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 123 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 126 | ERROR | [x] Short array syntax must be used to define arrays 127 | ERROR | [x] Short array syntax must be used to define arrays 134 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 137 | ERROR | [x] Short array syntax must be used to define arrays 138 | ERROR | [x] Short array syntax must be used to define arrays 145 | ERROR | [x] Expected 1 blank line after function; 0 found 146 | ERROR | [x] The closing brace for the class must have an empty line before it -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/seeds_layouts/src/Plugin/LayoutFieldBase.php -------------------------------------------------------------------------------------------------- FOUND 14 ERRORS AND 1 WARNING AFFECTING 15 LINES -------------------------------------------------------------------------------------------------- 21 | ERROR | [x] Doc comment short description must end with a full stop 43 | ERROR | [ ] Doc comment short description must start with a capital letter 53 | WARNING | [ ] Empty return statement not required here 57 | ERROR | [ ] Doc comment short description must start with a capital letter 64 | ERROR | [ ] Doc comment short description must start with a capital letter 71 | ERROR | [ ] Doc comment short description must start with a capital letter 78 | ERROR | [ ] Doc comment short description must start with a capital letter 84 | ERROR | [ ] Doc comment short description must start with a capital letter 91 | ERROR | [ ] Doc comment short description must start with a capital letter 98 | ERROR | [ ] Doc comment short description must start with a capital letter 102 | ERROR | [x] Use null coalesce operator instead of ternary operator. 124 | ERROR | [ ] Doc comment short description must start with a capital letter 131 | ERROR | [x] Doc comment short description must end with a full stop 134 | ERROR | [x] Parameter comment must end with a full stop 136 | ERROR | [ ] Description for the @return value is missing -------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/seeds_layouts/src/Plugin/LayoutFieldInterface.php ------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------- 16 | ERROR | [x] Doc comment short description must end with a full stop 21 | ERROR | [ ] Description for the @return value is missing 31 | ERROR | [ ] Description for the @return value is missing 58 | ERROR | [ ] Description for the @return value is missing ------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/seeds_layouts/src/Element/BlocksWrapper.php ------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------- 20 | ERROR | [x] There must be no blank lines after the function comment 42 | ERROR | [x] Expected newline after closing brace 65 | ERROR | [x] Expected newline after closing brace 65 | ERROR | [x] Newline required after opening brace ------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/seeds_layouts/seeds_layouts.module ---------------------------------------------------------------------------------------------- FOUND 11 ERRORS AFFECTING 10 LINES ---------------------------------------------------------------------------------------------- 17 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 18 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 19 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 50 | ERROR | [x] Use null coalesce operator instead of ternary operator. 50 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 56 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8 57 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 10 60 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8 61 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 10 82 | ERROR | [x] Expected newline after closing brace 115 | ERROR | [x] Use null coalesce operator instead of ternary operator. ---------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/contrib/seeds_layouts/seeds_layouts.info.yml ------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------- Time: 742ms; Memory: 12MB

Comments & Activities

Issue created by @bhaveshdas
Merge request !2Resolve #3436337 "Fix the issues" → (Open) created by bhaveshdas
Status changed to Needs review 8 months ago10:05am 28 March 2024
Comment 8 months ago →
🇮🇳India bhaveshdas
Status changed to Needs work 8 months ago10:11am 29 March 2024

Comment 8 months ago →

🇮🇳India amanbtr72

Added twig extension to command and got this error

phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,css,theme,info,txt,md,yml,twig modules/custom/doissues/seeds_layouts-3436337/

PHPCBF RESULT SUMMARY
------------------------------------------------------------------------------------------------------------------------
FILE                                                                                                    FIXED  REMAINING
------------------------------------------------------------------------------------------------------------------------
D:\wamp64\www\drupal10\modules\custom\doissues\seeds_layouts-3436337\templates\seeds-2col.html.twig     1      0
------------------------------------------------------------------------------------------------------------------------
A TOTAL OF 1 ERROR WERE FIXED IN 1 FILE
------------------------------------------------------------------------------------------------------------------------

Time: 1.97 secs; Memory: 14MB

Status changed to Needs review 8 months ago10:14am 29 March 2024
Comment 8 months ago →
🇮🇳India amanbtr72
fixed phpcs issue with twig extension
Status changed to Needs work 8 months ago3:33pm 29 March 2024

Comment 8 months ago →

🇵🇭Philippines clarkssquared

I applied MR !2 and there are still PHPCS issues that needs to be resolved.

➜  seeds_layouts git:(master) ✗ curl https://git.drupalcode.org/project/seeds_layouts/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 40643    0 40643    0     0  76147      0 --:--:-- --:--:-- --:--:-- 76975
patching file 'assets/images/seeds_1col.svg'
Patch creates file that already exists!  Assume -R? [y] y
patching file 'assets/images/seeds_2col.svg'
Patch creates file that already exists!  Assume -R? [y] y
patching file 'assets/images/seeds_3col.svg'
Patch creates file that already exists!  Assume -R? [y] y
patching file seeds_3col.svg
Patch creates file that already exists!  Assume -R? [y] 
patching file seeds_layouts.info.yml
1 out of 1 hunks failed--saving rejects to seeds_layouts.info.yml.rej
patching file seeds_layouts.install
Reversed (or previously applied) patch detected!  Assume -R? [y] y
patching file seeds_layouts.layouts.yml
Reversed (or previously applied) patch detected!  Assume -R? [y] 
patching file seeds_layouts.libraries.yml
Reversed (or previously applied) patch detected!  Assume -R? [y] 
patching file seeds_layouts.module
patching file 'src/Element/BlocksWrapper.php'
patching file 'src/Form/ColumnsForm.php'
patching file 'src/Form/FrameworkImportForm.php'
patching file 'src/Form/SeedsLayoutsConfigForm.php'
patching file 'src/Plugin/LayoutField/BackgroundImageField.php'
patching file 'src/Plugin/LayoutField/CheckboxField.php'
patching file 'src/Plugin/LayoutField/HideField.php'
patching file 'src/Plugin/LayoutField/SelectField.php'
patching file 'src/Plugin/LayoutField/WrapBlocksField.php'
patching file 'src/Plugin/LayoutField/WrapField.php'
patching file 'src/Plugin/LayoutFieldBase.php'
patching file 'src/Plugin/LayoutFieldInterface.php'
patching file 'src/Plugin/SeedsLayout.php'
Reversed (or previously applied) patch detected!  Assume -R? [y] 
4 out of 8 hunks failed--saving rejects to 'src/Plugin/SeedsLayout.php.rej'
patching file 'src/SeedsLayoutsManager.php'
2 out of 3 hunks failed--saving rejects to 'src/SeedsLayoutsManager.php.rej'
patching file 'templates/seeds-2col.html.twig'
➜  seeds_layouts git:(master) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml seeds_layouts 

FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/seeds_layouts/seeds_layouts.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------


FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/seeds_layouts/seeds_layouts.module
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
 94 | ERROR | The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/seeds_layouts/src/Plugin/SeedsLayout.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 3 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
  75 | ERROR   | [ ] Doc comment short description must start with a capital letter
 127 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 132 | ERROR   | [ ] The array declaration extends to column 111 (the limit is 80). The array content should be split up over multiple lines
 211 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 211 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 220 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 288 | ERROR   | [ ] The array declaration extends to column 159 (the limit is 80). The array content should be split up over multiple lines
 290 | ERROR   | [ ] The array declaration extends to column 110 (the limit is 80). The array content should be split up over multiple lines
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/seeds_layouts/src/SeedsLayoutsManager.php
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------
  50 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 175 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------

Time: 677ms; Memory: 12MB

➜  contrib git:(master) ✗

Status changed to Needs review 8 months ago6:02am 1 April 2024
Comment 8 months ago →
🇮🇳India bhaveshdas
Hello @clarkssquared ,

Might be you check in master branch that why its showing all issues.kindly review on this branch 3436337-fix-the-issues not in master branch

please check below screenshot added for reference

Thankyou !!
Comment 5 months ago →
🇮🇳India dev16.addweb
silvi.addweb → made their first commit to this issue’s fork.

Comment 5 months ago →

🇮🇳India dev16.addweb

Hi, I have fix below remaining phpcs issues. Please review

custom/masqurade_log/seeds_layouts/

FILE: /home/addweb/Drupal8-vagrant/web/web/contribution/drupal-10-3/web/modules/custom/seeds_layouts/src/Plugin/LayoutField/BackgroundImageField.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------
 42 | ERROR | Function return type is not void, but function has no return statement
 42 | ERROR | Description for the @return value is missing
------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 447ms; Memory: 12MB

Comment 5 months ago →

🇵🇭Philippines clarkssquared

I applied the updated MR !2 but it seems its not applying properly?

➜  seeds_layouts git:(main) ✗ curl https://git.drupalcode.org/project/seeds_layouts/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 40936    0 40936    0     0  80131      0 --:--:-- --:--:-- --:--:-- 81222
patching file 'assets/images/seeds_1col.svg'
Patch creates file that already exists!  Assume -R? [y] y
patching file 'assets/images/seeds_2col.svg'
Patch creates file that already exists!  Assume -R? [y] y
patching file 'assets/images/seeds_3col.svg'
Patch creates file that already exists!  Assume -R? [y] y
patching file seeds_3col.svg
Patch creates file that already exists!  Assume -R? [y] y
patching file seeds_layouts.info.yml
1 out of 1 hunks failed--saving rejects to seeds_layouts.info.yml.rej
patching file seeds_layouts.install
Reversed (or previously applied) patch detected!  Assume -R? [y] y
patching file seeds_layouts.layouts.yml
Reversed (or previously applied) patch detected!  Assume -R? [y] y
patching file seeds_layouts.libraries.yml
Reversed (or previously applied) patch detected!  Assume -R? [y] y
patching file seeds_layouts.module
patching file 'src/Element/BlocksWrapper.php'
patching file 'src/Form/ColumnsForm.php'
patching file 'src/Form/FrameworkImportForm.php'
patching file 'src/Form/SeedsLayoutsConfigForm.php'
patching file 'src/Plugin/LayoutField/BackgroundImageField.php'
patching file 'src/Plugin/LayoutField/CheckboxField.php'
patching file 'src/Plugin/LayoutField/HideField.php'
patching file 'src/Plugin/LayoutField/SelectField.php'
patching file 'src/Plugin/LayoutField/WrapBlocksField.php'
patching file 'src/Plugin/LayoutField/WrapField.php'
patching file 'src/Plugin/LayoutFieldBase.php'
patching file 'src/Plugin/LayoutFieldInterface.php'
patching file 'src/Plugin/SeedsLayout.php'
Reversed (or previously applied) patch detected!  Assume -R? [y] y
4 out of 8 hunks failed--saving rejects to 'src/Plugin/SeedsLayout.php.rej'
patching file 'src/SeedsLayoutsManager.php'
2 out of 3 hunks failed--saving rejects to 'src/SeedsLayoutsManager.php.rej'
patching file 'templates/seeds-2col.html.twig'
➜  seeds_layouts git:(main) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml seeds_layouts 

FILE: .../d10/drupal_local/web/modules/contrib/seeds_layouts/seeds_layouts.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------------


FILE: ...ts/d10/drupal_local/web/modules/contrib/seeds_layouts/seeds_layouts.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 94 | ERROR | The array declaration extends to column 93 (the limit is 80). The
    |       | array content should be split up over multiple lines
--------------------------------------------------------------------------------


FILE: .../drupal_local/web/modules/contrib/seeds_layouts/src/Plugin/SeedsLayout.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AND 3 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------------
  75 | ERROR   | [ ] Doc comment short description must start with a capital
     |         |     letter
 127 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
     |         |     question marks, colons, or closing parentheses
 132 | ERROR   | [ ] The array declaration extends to column 111 (the limit is
     |         |     80). The array content should be split up over multiple
     |         |     lines
 211 | WARNING | [ ] t() calls should be avoided in classes, use
     |         |     \Drupal\Core\StringTranslation\StringTranslationTrait and
     |         |     $this->t() instead
 211 | WARNING | [ ] t() calls should be avoided in classes, use
     |         |     \Drupal\Core\StringTranslation\StringTranslationTrait and
     |         |     $this->t() instead
 220 | WARNING | [ ] t() calls should be avoided in classes, use
     |         |     \Drupal\Core\StringTranslation\StringTranslationTrait and
     |         |     $this->t() instead
 288 | ERROR   | [ ] The array declaration extends to column 159 (the limit is
     |         |     80). The array content should be split up over multiple
     |         |     lines
 290 | ERROR   | [ ] The array declaration extends to column 110 (the limit is
     |         |     80). The array content should be split up over multiple
     |         |     lines
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...drupal_local/web/modules/contrib/seeds_layouts/src/SeedsLayoutsManager.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
  50 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
 175 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
--------------------------------------------------------------------------------

Time: 587ms; Memory: 12MB

➜  contrib git:(main) ✗

retaining the status to needs review for others if they can replicate my report.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

Merge Requests

!2Fix the issues reported by phpcs
Open

Comments & Activities

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

Merge Requests

!2Fix the issues reported by phpcsOpen

Comments & Activities

!2Fix the issues reported by phpcs
Open