Contrib.social

Automated Drupal 11 compatibility fixes for select_or_other

Open on Drupal.org →
Created on 24 March 2024, 8 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

4.1

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 8 months ago
    21 pass
  • Comment 8 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-127659

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.9
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !13Automated Project Update Bot fixes → (Merged) created by project update bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 8 months ago
    21 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 7 months ago
    21 pass
  • Comment 7 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-177898

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.1
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.1
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 7 months ago
    21 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 6 months ago
    18 pass, 2 fail
  • Comment 6 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-185727

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.1
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.1
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 6 months ago
    18 pass, 2 fail
  • Comment 6 months ago →
    System Message

    The last submitted patch, 5: select_or_other.4.x-dev.rector.patch, failed testing. View results →

  • First commit to issue fork.
  • Pipeline finished with Success
    4 months ago
    Total: 264s
    #259624
  • Comment 3 months ago →
    🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin

    That needs changes in the bot fork. In the moment #7 causes:
    error: tests/src/Unit/.gitlab-ci.yml: No such file or directory
    when trying to apply merge !13 on 2.0 dev

  • Comment 3 months ago →
    🇪🇸Spain rodrigoaguilera Barcelona

    I'm not sure I follow.
    What needs to be done in the 4.x branch (I'm not aware of any 2.x branch) is to install it in a D11 base and then check the output of the browser in the failing tests. Strangely the browser output is not available for the gitlab-ci run as an artifact

  • Comment 3 months ago →
    🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin

    @rodrigoaguilera: sorry for the versioning typo confusion in my previous comment, too many bug fix tabs open atm. Of course I was referring to the 4.0 dev branch (edited my previous comment accordingly). It seems something is not in sync. Sadly I still suffer from some trouble I still have with the new Gitlab workflows to explain better. The last commit in !13 "Move gitlab-ci.yml to proper location." somehow causes now that the green !13 merge shown on top of this issue is not usable as patch against 4.x dev (like usual in such Automoated core compatibility issues) because it assumes gitlab-ci.yml at file path tests/src/Unit/.gitlab-ci.yml now. So it seems the merge is now off track from the dev branch and refers to the previous commits (if that makes sense)?

  • Comment 3 months ago →
    🇪🇸Spain rodrigoaguilera Barcelona

    But I don't understand how is that an issue. There is a commit that creates a file in the wrong place and then another commit that moves it in the right place.
    The cumulative patch should be applicable to the latest 4.x since the MR is rebased.
    https://git.drupalcode.org/project/select_or_other/-/merge_requests/13.diff

    The pipeline is green because it currently tests against Drupal 10.
    The pipeline for Drupal 11 has some issues but "next major" is not a reason to fail the MR so it is still green.

  • Comment 3 months ago →
    🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin

    Sorry, missed your last comment.

    But I don't understand how is that an issue.

    No not an "issue" in that sense, really.

    There is a commit that creates a file in the wrong place and then another commit that moves it in the right place.

    Exactly. I just explained where I came from previously. So no worries. Thanks for keeping track on this and sorry if I confused you.

  • Pipeline finished with Success
    3 months ago
    Total: 254s
    #277929
  • Pipeline finished with Success
    3 months ago
    Total: 157s
    #278410
  • Merge request !1update bot only into 3434446-automated-drupal-11 → (Merged) created by dqd
  • Merge request !16Resolve #3434446 "Automated drupal 11" → (Closed) created by dqd
  • Pipeline finished with Success
    3 months ago
    Total: 185s
    #278415
  • Pipeline finished with Success
    3 months ago
    Total: 148s
    #278419
  • Pipeline finished with Success
    about 2 months ago
    Total: 216s
    #310876
  • Comment about 2 months ago →
    🇪🇸Spain rodrigoaguilera Barcelona

    rodrigoaguilera → changed the visibility of the branch 3434446-automated-drupal-11 to hidden.

  • Pipeline finished with Success
    about 2 months ago
    Total: 156s
    #310888
  • Comment about 2 months ago →
    🇪🇸Spain rodrigoaguilera Barcelona

    Thank you dqd for clarifying

    I run manually the steps of the test on a D11 installation and it was throwing an signature compatibility error when saving nodes.
    Fixed the signature in MR13

    Opt-in to the next major is not the default anymore so I enabled it on explicitly
    https://git.drupalcode.org/project/gitlab_templates/-/blob/main/includes...

    But now the current is D11 so phpunit is running with D11 and it is green, therefore I think this is ready for review.

  • Comment 29 days ago →
    🇨🇦Canada hansa11

    hansa11 → changed the visibility of the branch 3434446-automated-drupal-11 to active.

  • Status changed to Needs review 2 days ago
  • Comment 2 days ago →
    ivnish Kazakhstan

    https://git.drupalcode.org/issue/select_or_other-3434446/-/jobs/3062446

    Some tests has deprecations. I think needs to investigate and fix it

  • Comment 2 days ago →
    🇪🇸Spain rodrigoaguilera Barcelona

    rodrigoaguilera → changed the visibility of the branch project-update-bot-only to hidden.

  • Comment 2 days ago →
    🇪🇸Spain rodrigoaguilera Barcelona

    Good catch.
    Let me have a look

  • Pipeline finished with Failed
    2 days ago
    Total: 146s
    #356342
  • Comment 2 days ago →
    ivnish Kazakhstan

    Cool! I'm a maintainer now. Let's fix this module together :)

  • Pipeline finished with Failed
    2 days ago
    Total: 244s
    #356380
  • Comment 2 days ago →
    🇪🇸Spain rodrigoaguilera Barcelona

    I fixed the deprecations but now there is some tests failures. Need a deeper look. I can't right now

  • Comment 2 days ago →
    🇪🇸Spain rodrigoaguilera Barcelona

    rodrigoaguilera → changed the visibility of the branch project-update-bot-only to active.

  • Comment 2 days ago →
    🇪🇸Spain rodrigoaguilera Barcelona

    rodrigoaguilera → changed the visibility of the branch 3434446-automated-drupal-11 to hidden.

  • Pipeline finished with Success
    2 days ago
    Total: 153s
    #356431
  • Comment 2 days ago →
    🇪🇸Spain rodrigoaguilera Barcelona

    I got confused because the most updated branch was project-update-bot-only and the MR was oldest. I hid the outdated branch (opposite of what I did before).

    The branch now has no deprecations running phpunit. There still one risky test but I think that is out of scope of this issue.

    Glad to see one of the maintainers around :)

    The MR is ready to review again

  • Comment 1 day ago →
    System Message
  • Comment 1 day ago →
    System Message
  • Comment 1 day ago →
    ivnish Kazakhstan
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024