- Issue created by @project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β these changes make this module compatible with Drupal 11! π
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-127659These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.9
- palantirnet/drupal-rector: 0.20.1
- Assigned to olmyr
- Merge request !5Issue #3434257 by olmyr: Automated Drupal 11 compatibility fixes for rip β (Merged) created by olmyr
- Issue was unassigned.
- π©πͺGermany Anybody Porta Westfalica
Let's add a generic test and see if it's green!
- π©πͺGermany simonbaese Berlin
This module may not be relevant for Drupal 11. I'm not sure if we should bump this. Can you give your opinion?
- π©πͺGermany Anybody Porta Westfalica
This module may not be relevant for Drupal 11. I'm not sure if we should bump this. Can you give your opinion?
Well I just had a case where I needed it in D11, why don't you think it's relevant? I think there can still be orphaned permissions?
- π©πͺGermany simonbaese Berlin
The module addresses an issue in the upgrade path from Drupal 9 to Drupal 10. Is it possible to upgrade directly from 9 to 11?
- π©πͺGermany Grevil
@simonbaese, @Anybody and I require this module for Drupal 11, as we just finished a Drupal 7 to Drupal 11 migration, where this issue can happen as well.
So it is indeed still relevant!
- π©πͺGermany Grevil
Back to needs work, based on the GitLab comment.
- π©πͺGermany Anybody Porta Westfalica
The module addresses an issue in the upgrade path from Drupal 9 to Drupal 10. Is it possible to upgrade directly from 9 to 11?
Yeah that's the main purpose, but we had other cases where it is helpful to be able to remove orphaned permissions, for example the field permission module may create such cases. Same can happen for migrations from Drupal 6 or 7.
- π©πͺGermany simonbaese Berlin
I see. I have no problem with shipping these changes.
- π©πͺGermany Grevil
Alright. Adjusted accordingly. I removed the hard pipeline failure for phpcs and phpstan, but I can revert that change again, if you disagree and want them to make the pipeline fail.
- π©πͺGermany Anybody Porta Westfalica
No I think that's a very good idea. phpcs and phpstan can be solved in a separate issue. Thank you!
-
simonbaese β
committed d7e6169f on 1.1.x authored by
olmyr β
Issue #3434257 by olmyr, simonbaese, anybody, grevil: Automated Drupal...
-
simonbaese β
committed d7e6169f on 1.1.x authored by
olmyr β
- π©πͺGermany Anybody Porta Westfalica
Thank you very very much @simonbaese! :)
- π©πͺGermany Grevil
Great stuff @simonbaese! Thanks for the superfast reply / fix! π