- Issue created by @smustgrave
- π³π±Netherlands Lendude Amsterdam
I'm not sure if using
$plugin->pluginTitle()
in the selector is great, because there are no further explanations about what the options in the list are, it's probably best to be verbose there.I would like to see it used in the admin summary, so that you can see in the Views UI which (if any) default plugin has been selected without having to open the edit dialog.
- Status changed to Needs review
9 months ago 3:11pm 25 March 2024 - π³π±Netherlands Lendude Amsterdam
This would show something like this in the UI:
- π¬π§United Kingdom longwave UK
+1 to #2, seeing the default in the admin overview would be helpful.
- π³π±Netherlands Lendude Amsterdam
Managed to create MR now, updated the IS a bit
- Status changed to RTBC
9 months ago 2:18pm 26 March 2024 - πΊπΈUnited States smustgrave
Ran test-only feature for new assertion and get an expected failure
1) Drupal\Tests\views\Functional\Plugin\ArgumentDefaultTest::testArgumentDefaultPlugin Failed asserting that null matches expected 'Default: Argument default test'. /builds/issue/drupal-3433268/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:94 /builds/issue/drupal-3433268/core/modules/views/tests/src/Functional/Plugin/ArgumentDefaultTest.php:76 /builds/issue/drupal-3433268/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 FAILURES! Tests: 6, Assertions: 39, Failures: 1.
That was a super quick ticket less then 3 days wow!
- Status changed to Needs review
9 months ago 3:48pm 26 March 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Added question / thought to the MR.
- π³π±Netherlands Lendude Amsterdam
Yeah that is more readable, changed it, and added a small comment
- Status changed to RTBC
9 months ago 5:43pm 26 March 2024 - πΊπΈUnited States smustgrave
Feedback appears to be addressed from @alexpott.
- π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed 2a797ad166 to 11.x and 5ed3bcbfbd to 10.3.x. Thanks!
-
alexpott β
committed 5ed3bcbf on 10.3.x
Issue #3433268 by Lendude, smustgrave, longwave, alexpott: Use plugin...
-
alexpott β
committed 5ed3bcbf on 10.3.x
- Status changed to Fixed
9 months ago 1:16pm 27 March 2024 -
alexpott β
committed 2a797ad1 on 11.x
Issue #3433268 by Lendude, smustgrave, longwave, alexpott: Use plugin...
-
alexpott β
committed 2a797ad1 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.