Remove deprecated code from user module

obsidian_ → made their first commit to this issue’s fork.

obsidian_ → changed the visibility of the branch 3432868-remove-deprecated-code to hidden.

I think we missed a few deprecations because I was searching for "removed from drupal:11" but there are a number of instances of "removed in drupal:11", "required in drupal:11" and "will cause an error in drupal:11". The reason I didn't search for @deprecated is because it also matched drupal:12.

Adding the following to the issue summary:

• UserRequestSubscriber::__construct
• UserController::__construct
• User::hasPermission
• PermissionHandler::__construct
• UserLoginBlock::__construct

Removed remaining deprecations

One note on the MR - there's a deprecation for removal in 12.0.0 that should have been for 11.0.0 which I think we should go ahead and remove here, with a spin-off issue to fix the removal version in 10.3

Updated 7139 to remove that deprecation

Opened 7658 for 10.3.x to update deprecation message.

Thanks that looks good.

core/modules/user/src/Form/UserPasswordForm.php:      @\trigger_error('Passing $userNameValidator as \Drupal\Core\TypedData\TypedDataManagerInterface to ' . __METHOD__ . ' () is deprecated in drupal:10.3.0 and is removed in drupal:10.0.0. Pass a Drupal\user\UserValidator instead. See https://www.drupal.org/node/3431205', E_USER_DEPRECATED);

This one is obviously wrong, we should fix or remove it here, but what should it be?

core/modules/user/src/UserAuth.php:    @trigger_error(__METHOD__ . ' is deprecated in drupal:10.3.0 and will be removed from drupal 12.0.0. Implement \Drupal\user\UserAuthenticationInterface instead. See https://www.drupal.org/node/3411040');

This one is missing the colon in drupal:12.0.0, let's also fix that here.

The UserPasswordForm one should be removed in 11.0.0 - constructor for a form class, we can fix the deprecation message in the 10.3.x branch.

The UserAuth one - let's just fix the colon in the 10.3.x branch here too?

I have updated the 10.3.x branch per #16

Updated the 11.x branch.

I find 11.x branch ready

Committed 1c914f2 and pushed to 11.x. Thanks!
Committed 82bc1ee and pushed to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

obsidian_ → closed merge request !7139