Automated Drupal 11 compatibility fixes for menu_export

Created on 18 March 2024, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot β†’ official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot β†’ or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot β†’ , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue β†’ . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue β†’ .

πŸ“Œ Task
Status

Needs review

Version

1.4

Component

Code

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module β†’ these changes make this module compatible with Drupal 11! πŸŽ‰
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot β†’ to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #11-121090

    This patch was created using these packages:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.7
    3. palantirnet/drupal-rector: 0.20.1
  • First commit to issue fork.
  • Status changed to RTBC 20 days ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Composer file probably not needed for D11 but the info file is the only thing reported by upgrade status.

  • πŸ‡¬πŸ‡§United Kingdom somersoft

    @smustgrave At this moment composer.json is needed as the repository is a part of a web site project's composer.json's respositories section and to get a set of packages that composer is happy with.

        "repositories": [
            {
                "type": "vcs",
                "url": "https://git.drupalcode.org/issue/menu_export-3431947.git"
            }
        ],
        require: {
            "drupal/menu_export": "dev-project-update-bot-only"
        }
    

    Once it has been merged in then Drupal end-point service for 8+ will indicate that it compatable with core ^11 because of the update to menu_export.info.yml. At that point, as there are no dependencies, it can be removed.

  • πŸ‡¬πŸ‡§United Kingdom JamesOakley Kent, UK

    Can someone please clarify exactly what still needs to be done to make the module D11 compatible?

  • πŸ‡¬πŸ‡§United Kingdom somersoft

    @jamesoakley from the rector patch β†’ and merge request, the menu_export.info.yml file needs to report that it is compatible with D11 and remove the core information.

    diff --git a/menu_export.info.yml b/menu_export.info.yml
    index 9a41318..729c819 100644
    --- a/menu_export.info.yml
    +++ b/menu_export.info.yml
    @@ -2,6 +2,5 @@ name: Menu Export
     type: module
     description: 'This module exports and imports menus and menu links.'
     package: Development
    -core: 8.x
    -core_version_requirement: ^8 || ^9 || ^10
    +core_version_requirement: ^8 || ^9 || ^10 || ^11
     #configure: maintenance_notifications.form
    

    Once that change is made to or merged into 8.x-1.x branch and tagged(?) then magic can happen and the package indicates that compatible with the list of Drupal version on the package page. Drupal's composer end-point will also report that it requires core one of those core version too.

  • πŸ‡¬πŸ‡§United Kingdom somersoft

    I have run the upgrade_status β†’ on D11.1.6 for this packge and the report is

    CONTRIBUTED PROJECTS
    --------------------------------------------------------------------------------
    Menu Export project-update-bot-only-dev
    Scanned on Mon, 28/04/2025 - 12:47.

    1 warning found.

    web/modules/contrib/menu_export/menu_export.info.yml:
    +----------------+------+---------------------------------------------------------------------------------------------------------------------------------------------------------------+
    | status | line | message |
    +----------------+------+---------------------------------------------------------------------------------------------------------------------------------------------------------------+
    | Check manually | 5 | Value of core_version_requirement: ^8 | ^9 | ^10 | ^11 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687. |
    +----------------+------+---------------------------------------------------------------------------------------------------------------------------------------------------------------+

    which indicates that currently it is also will run on D12 as well. This report does not report on changing underlying functionality.

    Report from running the tests for the package.

    docker@cli:/var/www$ phpunit web/modules/contrib/menu_export/
    PHPUnit 10.5.45 by Sebastian Bergmann and contributors.

    Runtime: PHP 8.3.20
    Configuration: /var/www/phpunit.xml.dist

    . 1 / 1 (100%)

    Time: 00:08.321, Memory: 12.00 MB

    OK, but there were issues!
    Tests: 1, Assertions: 15, PHPUnit Deprecations: 1.

  • πŸ‡¬πŸ‡§United Kingdom JamesOakley Kent, UK

    So basically, it's ready to roll, it just needs the info file updating to say as much.

Production build 0.71.5 2024