- Issue created by @project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β these changes make this module compatible with Drupal 11! π
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #11-121090This patch was created using these packages:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.7
- palantirnet/drupal-rector: 0.20.1
- First commit to issue fork.
- Status changed to RTBC
20 days ago 5:39pm 17 April 2025 - πΊπΈUnited States smustgrave
Composer file probably not needed for D11 but the info file is the only thing reported by upgrade status.
- π¬π§United Kingdom somersoft
@smustgrave At this moment composer.json is needed as the repository is a part of a web site project's composer.json's respositories section and to get a set of packages that composer is happy with.
"repositories": [ { "type": "vcs", "url": "https://git.drupalcode.org/issue/menu_export-3431947.git" } ], require: { "drupal/menu_export": "dev-project-update-bot-only" }
Once it has been merged in then Drupal end-point service for 8+ will indicate that it compatable with core ^11 because of the update to menu_export.info.yml. At that point, as there are no dependencies, it can be removed.
- π¬π§United Kingdom JamesOakley Kent, UK
Can someone please clarify exactly what still needs to be done to make the module D11 compatible?
- π¬π§United Kingdom somersoft
@jamesoakley from the rector patch β and merge request, the menu_export.info.yml file needs to report that it is compatible with D11 and remove the core information.
diff --git a/menu_export.info.yml b/menu_export.info.yml index 9a41318..729c819 100644 --- a/menu_export.info.yml +++ b/menu_export.info.yml @@ -2,6 +2,5 @@ name: Menu Export type: module description: 'This module exports and imports menus and menu links.' package: Development -core: 8.x -core_version_requirement: ^8 || ^9 || ^10 +core_version_requirement: ^8 || ^9 || ^10 || ^11 #configure: maintenance_notifications.form
Once that change is made to or merged into 8.x-1.x branch and tagged(?) then magic can happen and the package indicates that compatible with the list of Drupal version on the package page. Drupal's composer end-point will also report that it requires core one of those core version too.
- π¬π§United Kingdom somersoft
I have run the upgrade_status β on D11.1.6 for this packge and the report is
CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Menu Export project-update-bot-only-dev
Scanned on Mon, 28/04/2025 - 12:47.1 warning found.
web/modules/contrib/menu_export/menu_export.info.yml:
+----------------+------+---------------------------------------------------------------------------------------------------------------------------------------------------------------+
| status | line | message |
+----------------+------+---------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Check manually | 5 | Value of core_version_requirement: ^8 | ^9 | ^10 | ^11 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687. |
+----------------+------+---------------------------------------------------------------------------------------------------------------------------------------------------------------+which indicates that currently it is also will run on D12 as well. This report does not report on changing underlying functionality.
Report from running the tests for the package.
docker@cli:/var/www$ phpunit web/modules/contrib/menu_export/
PHPUnit 10.5.45 by Sebastian Bergmann and contributors.Runtime: PHP 8.3.20
Configuration: /var/www/phpunit.xml.dist. 1 / 1 (100%)
Time: 00:08.321, Memory: 12.00 MB
OK, but there were issues!
Tests: 1, Assertions: 15, PHPUnit Deprecations: 1. - π¬π§United Kingdom JamesOakley Kent, UK
So basically, it's ready to roll, it just needs the info file updating to say as much.