Deprecate user_validate_name() and replace with service

UserPasswordForm has a copy-paste of user_validate_name() that could also be replaced here:

    // First, see if the input is possibly valid as a username.
    $name = trim($form_state->getValue('name'));
    $definition = BaseFieldDefinition::create('string')
      ->addConstraint('UserName', []);
    $data = $this->typedDataManager->create($definition);
    $data->setValue($name);
    $violations = $data->validate();
    // Usernames have a maximum length shorter than email addresses. Only print
    // this error if the input is not valid as a username or email address.
    if ($violations->count() > 0 && !$this->emailValidator->isValid($name)) {

Have not reviewed

But appears to have several test failures.

Thanks for the reviews. I feel like this could be simpler if we didn't need to use typed data as we are not validating an entity, but \Drupal\user\Plugin\Validation\Constraint\UserNameConstraintValidator assumes it is. 🤷

Also, since we are only checking the name, I think we can rename it to UserNameValidator.

Searched for user_validate_name() and appears all instances have been replaced.

Based on the small number in core assume that D11 should be fine for removal vs D12.

Test coverage can be seen here https://git.drupalcode.org/issue/drupal-3431203/-/jobs/1099143

I've added some review comments to address - thanks!

Addressed feedback.

Had a look for docs that say we require a @return annotation and couldn't find one. Only docs for describing the format of the @return annotation. https://www.drupal.org/docs/develop/standards/php/api-documentation-and-... →

For the @return statement. If phpcs doesn't complain about it being included think it can't hurt.

Addressed feedback.

Feedback appears to be addressed.

Given where we are in the release cycle and the number of usages I think we should push the deprecation of user_validate_name out to 12. See https://git.drupalcode.org/search?group_id=2&repository_ref=&scope=blobs...

Also I think we should update the code to call the new service for consistency.

Pushed the minor tweaks for #14

Committed 8e7d3e0 and pushed to 11.x. Thanks!
Committed 3194f76 and pushed to 10.3.x. Thanks!

kim.pepper → closed merge request !7069

Automatically closed - issue fixed for 2 weeks with no activity.