Contrib.social

Automated Drupal 11 compatibility fixes for config_views

Open on Drupal.org →
Created on 16 March 2024, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

2.1

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Comment about 1 year ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #11-120835

    This patch was created using these packages:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.7
    3. palantirnet/drupal-rector: 0.20.1
  • Status changed to Active 8 months ago
  • Comment 8 months ago →
    🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
  • Comment 8 months ago →
    🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin

    dqd → changed the visibility of the branch 2.0.x to hidden.

  • Merge request !10Resolve #3429482 "Drupal 11 compatibility" → (Merged) created by dqd
  • Pipeline finished with Canceled
    8 months ago
    Total: 124s
    #277343
  • Pipeline finished with Failed
    8 months ago
    Total: 201s
    #277344
  • Status changed to Needs work 3 months ago
  • Comment 3 months ago →
    🇬🇧United Kingdom scott_euser

    Test failure for D11:

    1) Drupal\Tests\config_views\Functional\DefaultViewsTest::testViews
Drupal\Core\Extension\Exception\UnknownExtensionException: Unknown themes: classy.
  • Comment 3 months ago →
    🇬🇧United Kingdom scott_euser

    scott_euser → changed the visibility of the branch project-update-bot-only to hidden.

  • Comment 3 months ago →
    🇬🇧United Kingdom scott_euser

    Okay tests now pass with this (but I've had to take the code from 🐛 Dynamic property issue in ConfigEntityQuery with PHP 8.2 RTBC for tests to pass otherwise the deprecation is a fatal error in php 8.3).

  • Pipeline finished with Success
    3 months ago
    Total: 150s
    #411178
  • Comment 3 months ago →
    🇬🇧United Kingdom scott_euser

    Added 🐛 Fix phpcs, phpstan, cspell Postponed for after this is merged (set it to postponed for now)

  • Pipeline finished with Skipped
    3 months ago
    #411212
  • Comment 3 months ago →
    System Message
  • Comment 3 months ago →
    🇬🇧United Kingdom scott_euser

    Thanks!

  • Comment 3 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Active 3 days ago
  • Comment 3 days ago →
    🇺🇸United States swirt Florida

    Setting this back to Active so it will continue to get any automated updates

    Accept automated changes until this issue is closed
    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

  • Comment about 23 hours ago →
    🇬🇧United Kingdom scott_euser

    Hmmm not sure that's the right approach because we should be granting credit for the work done. I instead added a scheduled monthly pipeline to Gitlab CI in case there is a deprecation added to D10 that is removed in D11 (though I think that's not possible now and only deprecations would happen in D11 for D12 which would get created as a new issue by the bot?). The scheduled pipeline will also flag deprecations added to D11 that will affect D12.

    I'll switch back to fixed for now, but feel free to disagree of course.

  • Comment about 16 hours ago →
    🇺🇸United States swirt Florida

    On other modules I have received updates after the initial round. I think it is related to either of two things

    1. Improvements made to the update bot / rector rather than newly announced deprivations.
    2. Inadvertantly adding new code to the module that actually contains a deprecation.

    Yes the credit awarding is an unfortunate casualty, but it is only a delay, as the this ticket can be closed like the D10 update ticket was once we are firmly in D11 and getting updates to D12. The community understands that credit is not always immediate.

    The directions are pretty clear at the top of the ticket, but I agree it would be nice if it spelled out when it is finally safe to close.

  • Comment about 16 hours ago →
    🇬🇧United Kingdom scott_euser

    Okay cool, let's leave it active then. Not sure we'll get any more drupal 11 fixes given we've got it working in Drupal 11 and there is a stable release for that and gitlab CI monthly pipeline should also notify on pipeline issues, but I'll set a reminder for summer 2026 D12 release and then we'll at least know for certain for the future.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024