- Issue created by @catch
- Status changed to Needs work
8 months ago 7:12pm 18 March 2024 - π¬π§United Kingdom catch
A few things going on here:
- the system/base library shouldn't be in system module at all, moved to core.libraries.yml and core/misc.
- we probably need to do the same for system.admin and system.maintenance since these are called by template_preprocess_maintenance_page(), but that might not be necessary to fix this specific issue and dependencies, potentially can happen in a follow-up.
- First commit to issue fork.
- Status changed to Needs review
8 months ago 10:16am 19 March 2024 - π¬π§United Kingdom catch
Tests are green. I implemented bc for anything declaring system/base as a library dependency but not for library overrides - personally I think a change record should be enough for those given it's essentially an alter hook.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
- the system/base library shouldn't be in system module at all, moved to core.libraries.yml and core/misc.
I bet
system/base
precedes the "core
extension" existing! π΄πAh, you specifically commented on that in #5. Well β¦ if a release manager thinks that's okay, then I'm fine with it too β you're totally right that it's far less common to do library overrides. And the changes in
claro.info.yml
can serve as an inspiration for how to do this.Just one remaining question regarding BC: how can a theme be compatible with both the "before" and "after" states in a single version?
- Status changed to Needs work
8 months ago 9:42am 21 March 2024 - π¬π§United Kingdom catch
Looking at
system/base
I found a tonne of issues which are now documented in π Move system/base component CSS to respective libraries where they exist Fixed and related issues. If we do those issues, there will be much less change to do here, so I think we should soft-postpone this issue to avoid moving things two or three times. - Status changed to Postponed
8 months ago 7:43am 5 April 2024 - π¬π§United Kingdom catch
Postponing this on π Move system/base component CSS to respective libraries where they exist Fixed π Refactor system/base library Needs work , we might even be able to just drop the calls altogether if we do those without having to manually load the libraries in the installer any more, or at least, it would be a very short list.