Add validation constraints to image.settings

Drupal\Tests\migrate_drupal_ui\Functional\d7\Upgrade7TestWithContentModeration::testUpgradeAndIncremental
Failed asserting that 29 is identical to 27.

I bet that's just two additional migration messages about invalid config.

#3: Yup, confirmed. https://git.drupalcode.org/issue/drupal-3425870/-/jobs/997495#L665

I've updated the test.

I was wondering if this should have explicit test coverage 🤔 We are adding a new Symfony validation constraint to Drupal here after all.

image.settings:preview_image itself is implicitly tested because ImageStylesPathAndUrlTest modifies that config object and saves it, which results in this validation logic running. So we know that the default config (preview_image: core/modules/image/sample.png) works fine for sure.

Thoughts, @phenaproxima? 🤔

I think that it absolutely cannot hurt to have explicit test coverage of that. It wasn't hard to write! Back to you.

Explicit test coverage of failing to pass validation in combination with lots of implicit test coverage of passing validation (see #8) seems a reasonable, pragmatic approach. 👍 (Although I'd understand if a core committer would prefer explicit test coverage of passing validation).

I fixed the migrations - having them fail just because we don't want to do a find and replace feels unnecessary.

Committed and pushed ad80289ed4 to 11.x and ffd6065a7c to 10.3.x. Thanks!

Thanks for https://git.drupalcode.org/project/drupal/-/merge_requests/6927/diffs?co..., @alexpott — I prefer that too but wasn't able to convince @phenaproxima 😄

Automatically closed - issue fixed for 2 weeks with no activity.