toolbar should get the list cache tag, not the individual cache tags

This won't work without the fix from 🐛 cache tags don't make it through to the toolbar Needs review also applied.

See commit suggestions on the merge request https://git.drupalcode.org/project/environment_indicator/-/merge_request...

atul_ghate → made their first commit to this issue’s fork.

HI @trackleft2 , I have worked on the suggested changes, please review.

Hi @atul_ghate, thanks for your help on this. Adding your change as a patch file.

Rerolling patch

Tested with these two patches together, and now when I save the configuration forms at either: /admin/config/development/environment-indicator/current or /admin/config/development/environment-indicator the toolbar is updated.

LGTM

            "drupal/environment_indicator": {
                "Toolbar should get the list cache tag, not the individual cache tags (3425788)": "https://www.drupal.org/files/issues/2024-06-05/3425788-8.patch",
                "Cache tags don't make it through to the toolbar (3425499)":"https://www.drupal.org/files/issues/2024-06-05/3425499-8.patch"
            },

Thanks!

Hi @isholgueras,

Thanks for merging the MR.

I noticed that I wasn't credited for resolving this issue. Could you let me know if there's something I might have missed?

I forgot to check the checkboxes for credit in the merge but I've added later an empty commit with the appropriate credit https://git.drupalcode.org/project/environment_indicator/-/commit/e01de5....

I'll ask to see how it should be done if this is not the way.

Hi isholgueras, we can just check the checkbox and save.