- Issue created by @joachim
- Status changed to Needs review
about 1 year ago 2:54pm 5 March 2024 - 🇬🇧United Kingdom joachim
This won't work without the fix from 🐛 cache tags don't make it through to the toolbar Needs review also applied.
- Merge request !37Fixed toolbar setting cache tags for each entity rather than the list cache tag. → (Merged) created by joachim
- Status changed to Needs work
11 months ago 1:06am 5 June 2024 - 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
See commit suggestions on the merge request https://git.drupalcode.org/project/environment_indicator/-/merge_request...
- First commit to issue fork.
- Status changed to Needs review
11 months ago 6:47am 5 June 2024 - 🇮🇳India atul_ghate
HI @trackleft2 , I have worked on the suggested changes, please review.
- 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
Hi @atul_ghate, thanks for your help on this. Adding your change as a patch file.
- Status changed to RTBC
11 months ago 4:07pm 5 June 2024 - 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
Tested with these two patches together, and now when I save the configuration forms at either: /admin/config/development/environment-indicator/current or /admin/config/development/environment-indicator the toolbar is updated.
LGTM
"drupal/environment_indicator": { "Toolbar should get the list cache tag, not the individual cache tags (3425788)": "https://www.drupal.org/files/issues/2024-06-05/3425788-8.patch", "Cache tags don't make it through to the toolbar (3425499)":"https://www.drupal.org/files/issues/2024-06-05/3425499-8.patch" },
- First commit to issue fork.
-
isholgueras →
committed 7de422f4 on 4.x authored by
joachim →
Issue #3425788: toolbar should get the list cache tag, not the...
-
isholgueras →
committed 7de422f4 on 4.x authored by
joachim →
- Status changed to Fixed
10 months ago 3:00pm 23 June 2024 -
isholgueras →
committed e01de5e5 on 4.x
Issue #3425788 by trackleft2, joachim, atul_ghate: toolbar should get...
-
isholgueras →
committed e01de5e5 on 4.x
- 🇮🇳India atul_ghate
Hi @isholgueras,
Thanks for merging the MR.
I noticed that I wasn't credited for resolving this issue. Could you let me know if there's something I might have missed?
- 🇪🇸Spain isholgueras
I forgot to check the checkboxes for credit in the merge but I've added later an empty commit with the appropriate credit https://git.drupalcode.org/project/environment_indicator/-/commit/e01de5....
I'll ask to see how it should be done if this is not the way.
Automatically closed - issue fixed for 2 weeks with no activity.