- Issue created by @joachim
- Status changed to Needs review
11 months ago 2:23pm 5 March 2024 - Status changed to Needs work
8 months ago 12:55am 5 June 2024 - πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
Please commit my suggestion https://git.drupalcode.org/project/environment_indicator/-/merge_request...
- Status changed to Needs review
8 months ago 3:29pm 5 June 2024 - πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
Tested with these two patches together, and now when I save the configuration forms at either: /admin/config/development/environment-indicator/current or /admin/config/development/environment-indicator the toolbar is updated.
LGTM
"drupal/environment_indicator": { "Toolbar should get the list cache tag, not the individual cache tags (3425788)": "https://www.drupal.org/files/issues/2024-06-05/3425788-8.patch", "Cache tags don't make it through to the toolbar (3425499)":"https://www.drupal.org/files/issues/2024-06-05/3425499-8.patch" },
- πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
trackleft2 β changed the visibility of the branch 4.x to hidden.
- πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
IMHO, this issue should be the next priority for this module since it fixes a major usability issue for testing other merge requests. It removes the need to clear the cache on every update to the environment indicator configuration.
- First commit to issue fork.
- Status changed to RTBC
6 months ago 8:31pm 7 August 2024 - πΊπΈUnited States nicxvan
Looks good, moving the tag merging outside the original location allows the context to be preserved.
- Status changed to Needs review
6 months ago 10:48pm 7 August 2024 - πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
I've updated this after it was reviewed and tested by the community with an update from @chx
See the slack conversation here: https://drupal.slack.com/archives/C1BMUQ9U6/p1723064619282849?thread_ts=... - Status changed to RTBC
6 months ago 11:55pm 7 August 2024 - πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
Uploading static patch to match the merge request.
- π¬π§United Kingdom pobster
Nice, RTBC as well. I'd forgotten all about this!
- First commit to issue fork.
-
isholgueras β
committed 8ffbd73b on 4.x authored by
joachim β
Issue #3425499 by trackleft2, joachim, nicxvan, pobster: Cache tags don'...
-
isholgueras β
committed 8ffbd73b on 4.x authored by
joachim β
- Status changed to Fixed
4 months ago 10:06am 12 October 2024 Automatically closed - issue fixed for 2 weeks with no activity.