- Issue created by @kentr
- 🇵🇱Poland jorgik
Just tested it on module version ^2.5, can confirm that it works great. Thank you!
- last update
6 months ago 62 pass, 2 fail - Status changed to Needs review
6 months ago 8:23pm 11 June 2024 - 🇺🇸United States kentr
I was keeping the merge request as a draft b/c I believed that it needs tests.
However, I'll let the maintainers decide that and have changed the merge request to
Ready
. - Issue was unassigned.
- 🇺🇸United States DamienMcKenna NH, USA
Thanks for the merge request, we'll try to review it soon.
As a reminder, when you're finished with your work please set the "Assigned" field to "Unassigned".
- First commit to issue fork.
- last update
6 months ago 62 pass, 2 fail - First commit to issue fork.
- 🇺🇸United States jennypanighetti
I just came here looking to add this!
I've applied the patch and ran `drush cr` but I don't yet see mainEntity in the sidebar of my node.
- 🇺🇸United States kentr
@jennypanighetti
With regard to the sidebar, a you referring to a visible part of the page? This patch by itself wouldn't add anything visible to a node.
It adds the option to configure the
mainEntity
property on a schema.orgProfilePage
item, which will add the property to the schema.org JSON in the HTML<head>
. - 🇺🇸United States kentr
I did not intend to hide the branch for everyone. I thought that was just for my view.
- 🇺🇸United States jennypanighetti
@kentr not the visible page, I meant the admin sidebar. I thought this was adding mainEntity to the WebPage item, but I see now it was split as a new item. I went in and added the new ProfilePage item to the allowed schemas and it shows now.
- Status changed to RTBC
about 1 month ago 9:23pm 13 November 2024 - 🇺🇸United States thejimbirch Cape Cod, Massachusetts
The MR applies and adds a new module and schema form for ProfilePage. Works as designed. Marking as RTBC. Thanks for the contribution!
Should there be a follow up issue to update documentation and the Schema WebPage module to recommend using ProfilePage instead?