- Issue created by @scott_euser
- Merge request !6709#3422845: Add example help keys to views.api.php β (Open) created by scott_euser
- Issue was unassigned.
- Status changed to Needs review
9 months ago 5:48am 21 February 2024 - π¬π§United Kingdom scott_euser
Minor thing, but would have saved me some time, so hoping this tiny addition saves someone else some time in the future. Thanks!
Before adding 'help' key to relationship:
After adding 'help' key to relationship:
- Status changed to RTBC
9 months ago 4:05pm 21 February 2024 - πΊπΈUnited States smustgrave
Seems like a straight forward improvement and makes sense to me (I think)
- Status changed to Needs work
9 months ago 10:30am 22 February 2024 The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Status changed to RTBC
9 months ago 11:38am 22 February 2024 - π¬π§United Kingdom scott_euser
Hmmm that's odd, no phpstan failures. Not sure what needs review bot is complaining about - will revert it back to RTBC. Thanks!
- π«π·France nod_ Lille
phpstan and .api.php files have issues in non-CI runs
- Status changed to Needs work
9 months ago 1:41pm 23 February 2024 - π«π·France nod_ Lille
Need to change the term so that we don't use dummy.
- Status changed to Needs review
9 months ago 3:44pm 23 February 2024 - π¬π§United Kingdom scott_euser
Apologies was trying to keep it in line with the existing code which called the field 'dummy' already + commented about that in that way, but given your steer have updated that + line 501 + the related comment (which you did not ask for, hope that's okay - if not I can create a follow-up).
- π¬π§United Kingdom scott_euser
Thanks! Maybe @smustgrave if you have time you could consider the latest tweaks and RTBC again?
- Status changed to RTBC
9 months ago 4:22pm 23 February 2024 - π«π·France nod_ Lille
got some issues with the pre-commit hooks (same issue the NR-bot runs into) so I'll be committing that when i figure out the workaround.
- π¬π§United Kingdom scott_euser
Sounds good, thank you both! Hope it's not too painful!
- Status changed to Fixed
9 months ago 10:05pm 23 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.