- Issue created by @kostyashupenko
- Status changed to Needs review
10 months ago 10:34am 15 February 2024 - ๐ช๐ธSpain ckrina Barcelona
@kostyashupenko good catch! I'm wondering if there's a way to do this all at one and maybe this fix will solve this issue so we don't have to add this extra attribute to every component? https://www.drupal.org/project/navigation/issues/3402592#mr174-note266578 โจ Reset theme css. Fixed
- ๐ฎ๐ณIndia Kanchan Bhogade
Hi @kostyashupenko
Checked on Drupal 11.x without a patch it looks good to me
if I missing something please let me know so it can be helpful to reproduce the issueAttaching screenshot
- ๐ท๐บRussia kostyashupenko Omsk
Re #5
i was thinking what i can do - i decided to switch logic a bit in CSS. Now `font-family: inherit` is still placed in two difference places, but that's why:
1. I want to keep such "base" styles only in the scope of navigation module
2. Top bar is placed in the difference place in DOM tree than admin toolbar.
Looks ok now i thinkRe #6
This issue can be reproduced only with some custom themes, not with core themes like Claro or like Olivero (the theme on your screenshot). These two themes have `button { font-family: inherit }` already. - Issue was unassigned.
- ๐ฎ๐ณIndia Kanchan Bhogade
Thank you @kostyashupenko able to reproduce the issue with your inputs.
I have tested MR !176 on Drupal version 10.2.2 with a custom theme
The patch was applied successfully...Result:
The Font issue for custom themes is resolved with MR !176
RTBC++Attaching screenshots for reference
Keeping in "needs review" for code verification
- ๐ช๐ธSpain ckrina Barcelona
What I meant in #5 is if it would it work to do something like this:
:where([data-admin-ui-initial-styles]) * { font-family: inherit; }
This way this would be defined in the
admin-initial-styles.css
for all components without the need to specify it on each component file.If that approach works it'd mean to postpone this issue until โจ Reset theme css. Fixed is in and this gets integrated in that file.
- Status changed to Needs work
10 months ago 2:13pm 11 March 2024 - ๐ช๐ธSpain ckrina Barcelona
@kostyashupenko is this still happening after merging โจ Reset theme css. Fixed ? And cane we maybe add this code in the new
admin-reset-sโtyles.pcss.cssโ
file? - Assigned to kostyashupenko
- Status changed to Needs review
9 months ago 4:24pm 29 March 2024 - Issue was unassigned.
- ๐ช๐ธSpain ckrina Barcelona
@kostyashupenko would it be possible to have testing instructions to test it on my local? Like which theme you are using, or which changes you are recreating to test it. Thanks!
- ๐ท๐บRussia kostyashupenko Omsk
@ckrina just enable core theme "Stark" and set it as default theme. Then visit homepage )
- Status changed to Fixed
9 months ago 7:25am 2 April 2024 - ๐ช๐ธSpain ckrina Barcelona
Tested locally and it works perfect, thanks! I also like the admin-reset-styles library on its own so we can move it into its own thing in the future.
Automatically closed - issue fixed for 2 weeks with no activity.