Font issue on user pages with custom themes

Created on 15 February 2024, 10 months ago
Updated 16 April 2024, 8 months ago

Standard profile installation
Latest 1.x navigation module
Enable Stark theme here /admin/appearance and set it as Default theme.
Visit homepage

๐Ÿ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

๐Ÿ‡ท๐Ÿ‡บRussia kostyashupenko Omsk

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @kostyashupenko
  • ๐Ÿ‡ท๐Ÿ‡บRussia kostyashupenko Omsk

    Gonna fix it quickly

  • Merge request !176Fix of font family for buttons โ†’ (Merged) created by kostyashupenko
  • Status changed to Needs review 10 months ago
  • ๐Ÿ‡ท๐Ÿ‡บRussia kostyashupenko Omsk
  • Pipeline finished with Success
    10 months ago
    Total: 148s
    #95696
  • ๐Ÿ‡ช๐Ÿ‡ธSpain ckrina Barcelona

    @kostyashupenko good catch! I'm wondering if there's a way to do this all at one and maybe this fix will solve this issue so we don't have to add this extra attribute to every component? https://www.drupal.org/project/navigation/issues/3402592#mr174-note266578 โœจ Reset theme css. Fixed

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Kanchan Bhogade

    Hi @kostyashupenko
    Checked on Drupal 11.x without a patch it looks good to me
    if I missing something please let me know so it can be helpful to reproduce the issue

    Attaching screenshot

  • Pipeline finished with Success
    10 months ago
    #98278
  • ๐Ÿ‡ท๐Ÿ‡บRussia kostyashupenko Omsk

    Re #5
    i was thinking what i can do - i decided to switch logic a bit in CSS. Now `font-family: inherit` is still placed in two difference places, but that's why:
    1. I want to keep such "base" styles only in the scope of navigation module
    2. Top bar is placed in the difference place in DOM tree than admin toolbar.
    Looks ok now i think

    Re #6
    This issue can be reproduced only with some custom themes, not with core themes like Claro or like Olivero (the theme on your screenshot). These two themes have `button { font-family: inherit }` already.

  • Pipeline finished with Success
    10 months ago
    Total: 149s
    #98279
  • Issue was unassigned.
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Kanchan Bhogade

    Thank you @kostyashupenko able to reproduce the issue with your inputs.

    I have tested MR !176 on Drupal version 10.2.2 with a custom theme
    The patch was applied successfully...

    Result:
    The Font issue for custom themes is resolved with MR !176
    RTBC++

    Attaching screenshots for reference

    Keeping in "needs review" for code verification

  • ๐Ÿ‡ช๐Ÿ‡ธSpain ckrina Barcelona

    What I meant in #5 is if it would it work to do something like this:

    :where([data-admin-ui-initial-styles]) * {
        font-family: inherit;
    }
    

    This way this would be defined in the admin-initial-styles.css for all components without the need to specify it on each component file.

    If that approach works it'd mean to postpone this issue until โœจ Reset theme css. Fixed is in and this gets integrated in that file.

  • Status changed to Needs work 10 months ago
  • ๐Ÿ‡ช๐Ÿ‡ธSpain ckrina Barcelona

    @kostyashupenko is this still happening after merging โœจ Reset theme css. Fixed ? And cane we maybe add this code in the new admin-reset-sโ€Žtyles.pcss.cssโ€Ž file?

  • Assigned to kostyashupenko
  • Status changed to Needs review 9 months ago
  • ๐Ÿ‡ช๐Ÿ‡ธSpain ckrina Barcelona

    @kostyashupenko is this still happening?

  • Pipeline finished with Success
    9 months ago
    #134146
  • Pipeline finished with Canceled
    9 months ago
    Total: 40s
    #134160
  • Issue was unassigned.
  • ๐Ÿ‡ท๐Ÿ‡บRussia kostyashupenko Omsk
  • Pipeline finished with Success
    9 months ago
    #134161
  • ๐Ÿ‡ช๐Ÿ‡ธSpain ckrina Barcelona

    @kostyashupenko would it be possible to have testing instructions to test it on my local? Like which theme you are using, or which changes you are recreating to test it. Thanks!

  • ๐Ÿ‡ท๐Ÿ‡บRussia kostyashupenko Omsk

    @ckrina just enable core theme "Stark" and set it as default theme. Then visit homepage )

  • ๐Ÿ‡ท๐Ÿ‡บRussia kostyashupenko Omsk
  • Pipeline finished with Canceled
    9 months ago
    Total: 85s
    #135100
  • Status changed to Fixed 9 months ago
  • ๐Ÿ‡ช๐Ÿ‡ธSpain ckrina Barcelona

    Tested locally and it works perfect, thanks! I also like the admin-reset-styles library on its own so we can move it into its own thing in the future.

  • Pipeline finished with Success
    9 months ago
    Total: 241s
    #135102
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    7 months ago
    Total: 180s
    #179461
  • Pipeline finished with Success
    7 months ago
    #179463
  • Pipeline finished with Success
    6 months ago
    Total: 1123s
    #214768
  • Pipeline finished with Success
    6 months ago
    Total: 137s
    #220332
  • Pipeline finished with Success
    6 months ago
    Total: 164s
    #220333
  • Pipeline finished with Success
    6 months ago
    Total: 193s
    #220338
  • Pipeline finished with Success
    5 months ago
    Total: 784s
    #235016
  • Pipeline finished with Success
    5 months ago
    Total: 822s
    #235025
Production build 0.71.5 2024