Remove unwanted dependency on toolbar module brought back by accident

Created on 15 February 2024, 10 months ago
Updated 1 March 2024, 10 months ago

Problem/Motivation

@johnpicozzi reported in Slack this:

Quick question here, I see the MR and issue to decouple navigation from Toolbar. However I'm getting a message on my status report that indicates I have the toolbar module installed. Which is true, however it is still a requirement for the navigation module. I'm thinking we may have missed removing it from navigation.info.yml. Is that accurate or am I missing something?

Checked the source code and found it was certainly TRUE.

Reviewed back the issue and MR for 📌 Decouple from Toolbar module Needs review and the dependency was actually removed from the navigation.info.yml file.
However, as part of Create the Top Bar Needs review the dependency was moved from the bottom to the top of the list.

So, when merging both branches into 1.x, module ended up having the dependency anyway.

Steps to reproduce

Open navigation.info.yml file and confirm that unwanted dependency is there.

Proposed resolution

  • Remove dependency on toolbar module in navigation.info.yml file
  • Confirm that there are no regressions

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇪🇸Spain plopesc Valladolid

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @plopesc
  • Status changed to Needs review 10 months ago
  • 🇪🇸Spain plopesc Valladolid

    MR created.

    Please add @johnpicozzi to the credited users list, as he found and reported the bug.

  • Pipeline finished with Success
    10 months ago
    Total: 148s
    #95455
  • 🇺🇸United States johnpicozzi Providence, RI

    Thanks for creating the issue, Will test the MR later today to ensure it resolves the issue. Will report back.

  • Status changed to RTBC 10 months ago
  • 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa

    looks good, can be moved to RTBC.

  • Status changed to Needs work 10 months ago
  • 🇪🇸Spain ckrina Barcelona

    I can disable the Toolbar, but then with Umami Editor and Authors don't have a way to access the administration menus anymore. Not sure if this should be addressed here or in a follow-up.

  • Status changed to RTBC 10 months ago
  • 🇷🇺Russia kostyashupenko Omsk

    It can be a follow-up. I just checked - navigation becomes visible once i'm granting permissions to "Author" role users in Umami.

    Added core task (postponed status).

    Restoring RTBC here

  • Status changed to Fixed 10 months ago
  • 🇪🇸Spain ckrina Barcelona

    Thanks @kostyashupenko! Merging this in then :)

  • Pipeline finished with Success
    10 months ago
    Total: 176s
    #96622
    • plopesc committed c9923730 on 1.x
      Issue #3421505: Remove unnecessary dependency on toolbar module.
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    9 months ago
    Total: 199s
    #136428
  • Pipeline finished with Success
    7 months ago
    Total: 214s
    #173492
  • Pipeline finished with Success
    7 months ago
    Total: 150s
    #173511
  • Pipeline finished with Success
    7 months ago
    Total: 160s
    #179393
  • Pipeline finished with Canceled
    7 months ago
    Total: 117s
    #179411
  • Pipeline finished with Success
    7 months ago
    #179416
  • Pipeline finished with Success
    7 months ago
    Total: 158s
    #179422
  • Pipeline finished with Canceled
    6 months ago
    Total: 188s
    #199154
  • Pipeline finished with Failed
    6 months ago
    Total: 227s
    #199156
  • Pipeline finished with Failed
    6 months ago
    Total: 243s
    #199164
  • Pipeline finished with Failed
    6 months ago
    Total: 380s
    #199177
  • Pipeline finished with Failed
    6 months ago
    Total: 247s
    #199298
  • Pipeline finished with Failed
    6 months ago
    Total: 247s
    #199307
  • Pipeline finished with Failed
    6 months ago
    Total: 241s
    #199322
  • Pipeline finished with Failed
    6 months ago
    Total: 254s
    #199342
  • Pipeline finished with Failed
    6 months ago
    Total: 224s
    #199344
  • Pipeline finished with Failed
    6 months ago
    #199349
  • Pipeline finished with Failed
    6 months ago
    #199359
  • Pipeline finished with Failed
    6 months ago
    Total: 244s
    #199368
  • Pipeline finished with Failed
    6 months ago
    #199386
  • Pipeline finished with Failed
    6 months ago
    Total: 213s
    #199401
  • Pipeline finished with Failed
    6 months ago
    Total: 218s
    #199404
  • Pipeline finished with Failed
    6 months ago
    Total: 222s
    #199416
  • Pipeline finished with Failed
    6 months ago
    Total: 248s
    #199423
  • Pipeline finished with Failed
    6 months ago
    Total: 313s
    #199427
  • Pipeline finished with Failed
    6 months ago
    Total: 227s
    #199430
  • Pipeline finished with Failed
    6 months ago
    Total: 246s
    #199467
  • Pipeline finished with Failed
    6 months ago
    Total: 231s
    #199477
  • Pipeline finished with Failed
    6 months ago
    #199539
  • Pipeline finished with Failed
    6 months ago
    Total: 252s
    #199567
  • Pipeline finished with Canceled
    6 months ago
    Total: 166s
    #199570
  • Pipeline finished with Success
    6 months ago
    Total: 294s
    #199572
  • Pipeline finished with Failed
    6 months ago
    Total: 1201s
    #212339
  • Pipeline finished with Success
    6 months ago
    Total: 1074s
    #212351
  • Pipeline finished with Success
    6 months ago
    Total: 136s
    #220328
  • Pipeline finished with Success
    6 months ago
    Total: 137s
    #220330
  • Pipeline finished with Success
    5 months ago
    Total: 795s
    #234839
Production build 0.71.5 2024