- Issue created by @plopesc
- Status changed to Active
10 months ago 6:34am 18 January 2024 - 🇪🇸Spain plopesc Valladolid
This can be activated once ✨ Add Gitlab CI integration Fixed has been merged.
- First commit to issue fork.
- Status changed to Needs review
10 months ago 7:07am 18 January 2024 - Status changed to Needs work
10 months ago 7:26am 18 January 2024 - 🇪🇸Spain plopesc Valladolid
Thank you for your valuable work here @kostyashupenko.
Forgot to assign it to myself so we were crossposting.
We ended up with the same solution :)
I'll add a couple of small changes on top of yours
- Status changed to Needs review
10 months ago 8:53am 18 January 2024 - 🇪🇸Spain plopesc Valladolid
I think this is ready for review.
While working on this, I found some inconsistencies in the way navigation items are generated, that lead to inconsistent item IDs and classes in multilingual sites.
Creating a follow-up issue for that purpose.
To test this issue:
- Enable Navigation and disable Toolbar module
- Add "Access navigation bar" permission to intended roles
- Confirm that there are no regressions
- Status changed to RTBC
10 months ago 2:09pm 18 January 2024 - 🇨🇦Canada m4olivei Grimsby, ON
Looks great! Thanks for doing this. Nice to see phpstan all clean here as well.
- Status changed to Fixed
10 months ago 6:34pm 29 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.