Convert Editor plugin discovery to attributes

Converted Editor plugin discovery to attributes.

Converted Editor plugin discovery to attributes.

Thanks! 😊 Could you please convert this to a merge request, for much faster test results?

MR is up, added feedback and suggestions to the MR.

Accepted the other suggestion, to fix the spelling error.

I'm the subsystem maintainer and would like to be able to sign off on this. Love where this is going! 😄👍

Appears to phpcs and stan errors.

Because \Drupal\editor\Plugin\EditorPluginInterface::getJSSettings() and \Drupal\editor\Plugin\EditorPluginInterface::getLibraries() inappropriately are using the concrete Editor class in their signature rather than EditorInterface, an awkward aliasing-upon-using was necessary 😥

As far as I'm concerned, this is ready (except for the one comment nit that is yet to be applied).

I can reproduce the test failure locally. It's in a test that was added >9 years ago, in #2442255: Changing text formats on a field makes it impossible to edit. → .

The sole remaining unresolved thread is still not resolved, and it's about fixing a big bug in the current MR: https://git.drupalcode.org/project/drupal/-/merge_requests/6776#note_278485

Ruturaj Chaubey → made their first commit to this issue’s fork.

This looks ready to me now!

But one test is failing:

Drupal\FunctionalJavascriptTests\Ajax\AjaxTest::testAjaxFocus
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'edit-textfield-3'
+'edit-textfield-2'

🤔 Re-testing…

Appears all feedback has been addressed

All instances replaced

Tests are green :)

Committed e715970 and pushed to 11.x. Thanks!
Committed c84ae09 and pushed to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.