Convert FieldType plugin discovery to attributes

Postponed on 📌 Convert DataType plugin discovery to attributes Fixed

📌 Convert DataType plugin discovery to attributes Fixed is in so this is unblocked.

Can we update the docs for hook_field_info_alter in field.api.php here too? There are references to the annotation class but we should update to the attribute class.

#6 Done.

I was also questioning how these worked with Annotation\FieldType as they weren't defined anywhere I can see:

    public readonly array $config_dependencies = [],
    public readonly array $column_groups = [],
    public readonly array $serialized_property_names = [],

#7 I think we can remove those. They are the additional keys mentioned at the top of the attribute/annotation class. Since the attribute values get converted to an array they don't need to be defined.

Actually I think if we need to remove them then we need an alter hook to add the values in.

What I'm doing in the entity type issue is add an explicit additional key where you can put it arbitrary settings.

But some of these we probably should define if they're part of the official API.

serialized property names is part of a security issue that went in a while ago, column_groups is afaik mostly used for content _translation, not sure about config dependencies. It's used in \Drupal\Tests\field\Kernel\TestItemWithDependenciesTest, would probably need to check the issue that added this to see what the real use cases are.

@Berdir #10 i had a look at 📌 Convert entity type discovery to PHP attributes RTBC and doesn't look this you are doing this anymore?

I have left the properties in for now.

Re: config_dependencies I found this in the docs for \Drupal\Core\Config\Entity\ConfigDependencyManager

 * Classes for configurable plugins are a special case. They can either declare
 * their configuration dependencies using the calculateDependencies() method
 * described in the paragraph above, or if they have only static dependencies,
 * these can be declared using the 'config_dependencies' annotation key.

Applied the MR searched for @FieldType all instances have been replaced
Verified $deriver is there (something had to check from previous attribute tickets)
Tests are all green, showing nothing broke.

Believe this is good

Addressed feedback so back to NR

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

All feedback appears to be addressed here.

Committed and pushed cf09596544 to 11.x and 4afc682d90 to 10.3.x. Thanks!

kim.pepper → closed merge request !6874

Automatically closed - issue fixed for 2 weeks with no activity.