Dependency tree of mathieuviossat/arraytotexttable causes compatibility issues with PHP 8.2 and 8.3

Thanks for the report. Looks like this requires third party fixes.

Unrelated to Upgrade Status.

It is mathieuviossat/arraytotexttable not compatible with PHP 8.3, so not the latest version is downloaded so conflict between zend and laminas.

I made a PR on Github: https://github.com/viossat/arraytotexttable/pull/11

In my case I was stucked with mathieuviossat/arraytotexttable 1.0.7, while latest version is 1.0.10.

PS: I missed comment #3 while posting comment 4, so I don't know if the issue should be kept opened for information.

🐛 [PHP 8.2] Composer - Upgrade Status conflicts with core 10.1.5 Active is very similar

PR merged and new version of mathieuviossat/arraytotexttable available! \o/

But problem somewhere else. I tracked it down:

- drupal/core-recommended 10.2.3 requires psr/container (~2.0.2).
- Which prevents laminas/laminas-servicemanager to be installed on version >3.22.0 (PHP 8.3 compat). (because it needs psr/container 1)
- Which prevents laminas/laminas-text to be installed on version >2.11.0 (PHP 8.3 compat).
- Which prevents mathieuviossat/arraytotexttable to be installed on the latest version.

I do not copy/past composer output here for readability.

The problem is that Major version 4 of laminas/laminas-servicemanager is not marked as PHP 8.3 compatible... Because major version 4 of laminas/laminas-servicemanager is psr/container 2 compatible.

It is unfortunate that https://github.com/laminas/laminas-servicemanager/blob/4.0.0-rc2/compose... also does not yet support PHP 8.3. Would a 4.0.0-rc3 of servicemanager help? https://github.com/laminas/laminas-servicemanager/commits/4.0.x/ seems to not have much else since rc2. An issue there to request an RC3 would probably be worth it / helpful :)

Also Drupal core requires psr container 2 since Drupal 10.0. So looks like the combo of that and PHP 8.3 is causing problems? In 🐛 [PHP 8.2] Composer - Upgrade Status conflicts with core 10.1.5 Active it is also claimed that this already causes problems on PHP 8.2.

The latest laminas-text from https://github.com/laminas/laminas-text/blob/2.11.0/composer.json did support PHP 8.3.0, so this seems to be down to laminas/laminas-servicemanager not having a PHP 8.3 compatible release.

Ok after various trials in a gitpod instance I figured its probably best to go with a text table generator that has much less dependencies. We only use the whole thing in one place after all :D So we can replace with a more lightweight solution like https://packagist.org/packages/dekor/php-array-table

With this MR on drupalpod, I can verify the new dependency is used:

gitpod /workspace/DrupalPod (main) $ composer show drupal/upgrade_status
Notice: running 'composer show drupal/upgrade_status' in ddev
name     : drupal/upgrade_status
descrip. : Review Drupal major upgrade readiness of the environment and components of the site.
keywords : 
versions : * 4.x-dev
type     : drupal-module
license  : GNU General Public License v2.0 or later (GPL-2.0-or-later) (OSI approved) https://spdx.org/licenses/GPL-2.0-or-later.html#licenseText
homepage : http://drupal.org/project/upgrade_status
source   : []  
dist     : [path] repos/upgrade_status 8e9851b3b4666d8c3f2a1d699a04cf8dfe75f582
path     : /var/www/html/repos/upgrade_status
names    : drupal/upgrade_status

requires
dekor/php-array-table ^2.0
mglaman/phpstan-drupal ^1.0.0
nikic/php-parser ^4.0.0
phpstan/phpstan-deprecation-rules ^1.0.0
symfony/process ^3.4|^4.0|^5.0|^6.0
webflo/drupal-finder ^1.2

I can require Search API Solr on top of this without issue:

gitpod /workspace/DrupalPod (main) $ composer require drupal/search_api_solr
Notice: running 'composer require drupal/search_api_solr' in ddev
./composer.json has been updated
Running composer update drupal/search_api_solr
Loading composer repositories with package information
Updating dependencies
Lock file operations: 6 installs, 0 updates, 0 removals
  - Locking drupal/search_api (1.31.0)
  - Locking drupal/search_api_solr (4.3.2)
  - Locking halaxa/json-machine (1.1.4)
  - Locking laminas/laminas-stdlib (3.19.0)
  - Locking maennchen/zipstream-php (3.1.0)
  - Locking solarium/solarium (6.3.5)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 6 installs, 0 updates, 0 removals
  - Downloading halaxa/json-machine (1.1.4)
  - Downloading solarium/solarium (6.3.5)
  - Downloading maennchen/zipstream-php (3.1.0)
  - Downloading laminas/laminas-stdlib (3.19.0)
  - Downloading drupal/search_api (1.31.0)
  - Downloading drupal/search_api_solr (4.3.2)
  - Installing halaxa/json-machine (1.1.4): Extracting archive
  - Installing solarium/solarium (6.3.5): Extracting archive
  - Installing maennchen/zipstream-php (3.1.0): Extracting archive
  - Installing laminas/laminas-stdlib (3.19.0): Extracting archive
  - Installing drupal/search_api (1.31.0): Extracting archive
  - Installing drupal/search_api_solr (4.3.2): Extracting archive
7 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
95 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
PHP CodeSniffer Config installed_paths set to ../../drupal/coder/coder_sniffer,../../sirbrillig/phpcs-variable-analysis,../../slevomat/coding-standard,vendor/drupal/coder/coder_sniffer
phpstan/extension-installer: Extensions installed
> repos/add-project-as-symlink.sh
Replace project with a symlink
No security vulnerability advisories found.
Using version ^4.3 for drupal/search_api_solr

The text to table conversion is as good as before:

gitpod /workspace/DrupalPod (main) $ drush upgrade_status:analyze admin_toolbar
Notice: running 'drush upgrade_status:analyze admin_toolbar' in ddev
 [notice] Processing /var/www/html/web/modules/contrib/admin_toolbar.

================================================================================
Admin Toolbar,  3.4.2
Scanned on Wed, 02/21/2024 - 10:39

FILE: web/modules/contrib/admin_toolbar/admin_toolbar_search/src/SearchLinks.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 123  Relying on entity queries to check access by default is     
                    deprecated in drupal:9.2.0 and an error will be thrown from 
                    drupal:10.0.0. Call                                         
                    \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with
                    TRUE or FALSE to specify whether access should be checked.  
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/admin_toolbar/admin_toolbar_tools/src/Plugin/Derivative/Extr
aLinks.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 114  Relying on entity queries to check access by default is     
                    deprecated in drupal:9.2.0 and an error will be thrown from 
                    drupal:10.0.0. Call                                         
                    \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with
                    TRUE or FALSE to specify whether access should be checked.  
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/admin_toolbar/admin_toolbar_search/admin_toolbar_search.modu
le

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 76   The 'admin_toolbar_search/search' library is not defined    
                    because the defining extension is not installed. Cannot     
                    decide if it is deprecated or not.                          
--------------------------------------------------------------------------------
Check manually 120  The 'admin_toolbar_search/search' library is not defined    
                    because the defining extension is not installed. Cannot     
                    decide if it is deprecated or not.                          
--------------------------------------------------------------------------------

FILE: web/modules/contrib/admin_toolbar/admin_toolbar.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^9.2 || ^10 is not       
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/admin_toolbar/admin_toolbar_links_access_filter/admin_toolba
r_links_access_filter.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^9.2 || ^10 is not       
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/admin_toolbar/admin_toolbar_search/admin_toolbar_search.info
.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^9.2 || ^10 is not       
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/admin_toolbar/admin_toolbar_tools/admin_toolbar_tools.info.y
ml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^9.2 || ^10 is not       
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

Look good?

Gábor Hojtsy → credited nsavitsky → .

Gábor Hojtsy → credited PapaGrande → .

Carrying credits from 🐛 [PHP 8.2] Composer - Upgrade Status conflicts with core 10.1.5 Active now that this resolves that too.

Gábor Hojtsy → credited rishabjasrotia → .

Also carrying credits from 💬 Support for PHP 8.2 and Search API Solr compatibility Closed: duplicate .

Gábor Hojtsy → credited DrupalDope → .

Gábor Hojtsy → credited samir_shukla → .

And applying credits for 🐛 Upgrade Status 4.0.0 is not compatible with D10 upgrade Closed: duplicate which is also a duplicate.

✨ Add support for PHP 8.2 Closed: duplicate was also a duplicate but credits are already here.

Added tests prove this works on PHP 8.3 and will ensure this keeps working on PHP 8.3. Thanks all for your effort and sorry this took so much time! Enjoy!

Hi,

Thanks a lot!

I confirm that now I can add Search API Solr. Composer automatically took dev version of Upgrade Status for compatibility.

Automatically closed - issue fixed for 2 weeks with no activity.