πŸ‡΅πŸ‡±Poland @nsavitsky

Account created on 10 January 2012, over 12 years ago
#

Recent comments

πŸ‡΅πŸ‡±Poland nsavitsky

Hey @gΓ‘bor-hojtsy, sorry for late response, I have just received notification.

>Why are you getting a different result?

Well, I guess that it is due the fact that I had this issue few months back (oct 2023), probably new version of the dependency arrived (as I actually expected in the ticket description), and conflict was resolved for PHP 8.2. I see that you replaced MathieuViossat\Util\ArrayToTextTable with dekor\ArrayToTextTable library to also support PHP 8.3 and I think this is great solution. Thank you very much for taking care!

πŸ‡΅πŸ‡±Poland nsavitsky

Ouch, this is painful. The moving actions to new column obviously crashed functional testing. I'll try to find some time to update tests if my fix makes sense.

πŸ‡΅πŸ‡±Poland nsavitsky

I forgot to add patch itself. Here it goes.

πŸ‡΅πŸ‡±Poland nsavitsky

@hlopes Thank you very much for this patch and description, it helped me so much to understand what happened with paragraphs widget after 10.2 update.

So, if I understand correctly, in 10.2 we have "very special" new column for having actions. It looks like the problem is more complex than the case with cardinality = 1, because with 1.x paragraphs widget shows empty table cell (which actually breaks css/js) and shows actions in the content/title cell. I guess the correct approach will be to actually use this new cell, instead of hiding. That's why I extended the patch of @hlopes to implement this solution.

It works great with Claro.

Before patch:

After patch:

Unfortunately, it doesn't look good with Gin, because it shows paragraphs widget using "display:block" and has some magic css for calculating width and I don't really understand how it works (but it was broken before patch too, so it doesn't make it any worse :) ).

πŸ‡΅πŸ‡±Poland nsavitsky

Okay, I guess I will ease the pain for someone like me who needs to update old project with existing content made by Color API/JQuery Colorpicker fields to Drupal 10. Here is how to make it works using composer.

First, until this issue is merged, you need to say composer that you want to use code from merge request as the source. Modify repositories section in composer.json like this.

    "repositories": [
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8",
            "exclude": [
                "drupal/jquery_colorpicker"
            ]
        },
        {
            "type": "composer",
            "url": "https://asset-packagist.org"
        },
        {
            "type": "package",
            "package": {
                "name": "drupal/jquery_colorpicker",
                "version": "dev-3310798-implement-a-subscriber",
                "type": "drupal-module",
                "source": {
                    "url": "https://git.drupalcode.org/issue/jquery_colorpicker-3310798.git",
                    "type": "git",
                    "reference": "3310798-implement-a-subscriber"
                }
            }
        }
    ]

Now, run "composer require drupal/jquery_colorpicker:dev-3310798-implement-a-subscriber". Composer will install the module using the source code from merge request #7.

Next, you need to add JQuery Colorpicker vendor library. For some reason it was not installed in my case on previous step. Run "composer require jaypan/jquery-colorpicker:~1.0.1".

Almost there. Last step is to apply patch from https://www.drupal.org/project/vendor_stream_wrapper/issues/3325235 β†’ which helps Vendor Stream Library to handle relative URLs from CSS.

            "drupal/vendor_stream_wrapper": {
                "https://www.drupal.org/i/3325235": "https://git.drupalcode.org/project/vendor_stream_wrapper/-/merge_requests/6/diffs.patch"
            }

And ta-da! Tested on Drupal 10.1.5 and PHP 8.1.

πŸ‡΅πŸ‡±Poland nsavitsky

@abramm This is just wow. First, this patch saved me a lot of time and, second, this patch is just masterclass. Thank you so much. I have updated your patch for 8.x.-6.x and it works just perfect.

Production build 0.69.0 2024