UI refers to "files" when you can only upload one file

patch enclosed. #multiple is set based on the number of files upload allowed. this sets the ui text properly

@sukr_s

MR fails pipeline due to phpcs, can you fix that i can review the MR, Thanks

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

PHPCBF issue fixed

As a bug will need a failing test to show the issue.

@smustgrave The fix resolves correctness of English in UI (plural vs. singular). Not sure how to add tests for this. If you can point to some documentation, that would be helpful.

MR has a test failure

UI changes should also have before/after screenshots in the issue summary.

Tests can be a simple assertion added to an existing test.

MR updated with fix and test cases have been updated as well.

Left a comment.

following line is the positive test cases.

$choose_files->hasButton('Choose file');

The button label has to change to "Choose file". I believe there is no way to assert this (or?). Attach screenshot from the automated run that shows that the label has been successfully changed

Yea in that case I think the negative assertions should be fine.

One question on the MR.

The original code was always for "multiple files" and the test cases as well. The UI showed upload "files" even when a single file was being uploaded. So the fix was for ensuring that the right text is shown in the UI in case of single file upload. No other functionality or test cases are affected. e.g. line 300

 // Assert we can add multiple files.
 $this->assertTrue($assert_session->fieldExists('Add files')->hasAttribute('multiple'));

tests for multiple files

Ahh yeah, bad ctrl-f on my part it looks like, I can see coverage for both 'Add file' and 'Add files' now.

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.