- Issue created by @kingdutch
- Merge request !6421Issue #3418691: ckeditor5 module has an invalid config schema which causes POTX to fail β (Closed) created by kingdutch
- Status changed to Needs review
11 months ago 4:29pm 1 February 2024 - π³π±Netherlands kingdutch
Created a merge request against 10.2.x with the required change.
Credits to ronaldtebrake β for debugging this in our codebases and finding the culprit.
- πΊπΈUnited States dww
Good find! The change itself is small, looks good, and makes sense.
However, I'm not sure if we need a test for this. Typically we do, but this seems like a bit of a weird case. I'm going to ping some folks in #bugsmash in Slack about it to get more input. But tentative +1 to RTBC'ing this as-is to fix this before any more 10.2.x releases go out.
- π¬π§United Kingdom catch
I think it's OK to stop the bleeding without test coverage, but we should open a follow-up to add it so we don't do a similar thing again.
- πΊπΈUnited States dww
Great, thanks! π Add automated test coverage that POTX works against all of core Active
- Status changed to RTBC
11 months ago 10:47pm 1 February 2024 - πΊπΈUnited States dww
Oh, and I guess that means I can RTBC this, since I didn't touch the code. Thanks again!
- πΊπΈUnited States dww
Also crediting @kingdutch for the MR and myself for reviews, followup, etc.
-
larowlan β
committed ea0ae600 on 10.2.x
Issue #3418691 by Kingdutch, dww, ronaldtebrake: ckeditor5 module has an...
-
larowlan β
committed ea0ae600 on 10.2.x
- Status changed to Fixed
11 months ago 10:56pm 1 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.