Introduce Mapping::getValidKeys(), ::getRequiredKeys() etc.

Wim Leers → credited alexpott → .

Wim Leers → credited bircher → .

Wim Leers → credited borisson_ → .

MR coming shortly…

MR live.

Note that per #3364108-73: [PP-2] Configuration schema & required keys → , this is missing test coverage in MappingTest and \Drupal\KernelTests\Core\TypedData\ValidKeysConstraintValidatorTest for %key.

1. @phenaproxima's rephrasings look good 👍
2. Draft CR → created.
3. Pushed explicit test coverage for [%parent.%parent.something], in addition to the test coverage for [%parent.something] I had already added.

I believe this is ready for final review now.

I think the test coverage for this is now complete, I can't find anything I would change about this, and it makes reviewing/implementing the parent issue a lot simpler.

There is already a big discussion over in the parent issue on how we ended up here as well, so while this issue is missing the complete story, there is more than enough documentation/information to be found there, I'm not sure if we should copy some of the information from there to this issue's summary to make it more clear?

In any case, I think codewise this issue looks good to go in my opinion

Going to put this back to needs review as it has received significant changes post rtbc.

Thanks, was about to do that after being deep in the code for hours 🙈

I don't see much to complain about here. My feedback is asking for readability improvements, if possible, in the very complex code. But even with that, it's well-documented, and could be refactored later if needed - especially because there's such extensive test coverage.

I feel okay RTBCing this, since it's a major blocker. I only wrote some of the code comments, but didn't write any of the logic.

Incorporated all feedback 👍

Committed 007c0c7 and pushed to 11.x. Thanks!

Follow-up: 📌 Refine ValidKeysConstraintValidator's messages: use #3401883's new Mapping infrastructure Needs review .

Automatically closed - issue fixed for 2 weeks with no activity.

I doubt folks will see this comment since this issue is already closed, but FYI: 🐛 ckeditor5 module has an invalid config schema which causes POTX to fail Needs review