Correct migrate related words

Open on Drupal.org →

Created on 28 January 2024, 5 months ago

Updated 3 March 2024, 4 months ago

Problem/Motivation

While scanning a list of spelling errors and the related files I notices that some words had a significant number of migration files. Since I am familiar with migrate I thought this would be an easy set of words for me.

Steps to reproduce

Proposed resolution

In cases where the word is the name of a database field, the best option is to add an ignore line at the top of the file.
In some files, $mlid is changed to $menu_link_id instead of adding an ignore line and $parent_mlid to $parent_menu_link_id.

daycount
idconflict
imagecache - preparation for removal is here but it will be removed in 📌 Remove 'fast_404.excluded_paths' from system.performance.yml Needs work
mlid
multifield
newnode
onoff
otsikko
plid
textgroup
totalcount

Merge request link

Remaining tasks

Review, especially the variable renaming

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task

Status

Fixed

Version

11.0 🔥

Component

Last updated about 13 hours ago

Created by

🇳🇿New Zealand quietone New Zealand

Live updates comments and jobs are added and updated live.

cspell error

Needs Review Queue Initiative

Sign in to follow issues

Merge Requests

!6357Correct migrate related words
Closed
🇳🇿New Zealand quietone
updated 4 months ago

Comments & Activities

Issue created by @quietone
Merge request !6357Resolve #3417669 "Correct migrate related" → (Closed) created by quietone
Pipeline finished with Success
5 months ago
Total: 658s
#83831
Status changed to Needs review 5 months ago12:27am 29 January 2024
Comment 5 months ago →
🇳🇿New Zealand quietone New Zealand
Status changed to RTBC 5 months ago5:24pm 29 January 2024
Comment 5 months ago →
🇺🇸United States smustgrave
Refactoring of moving words to the actual files seems fine. Variable updates didn't seem to break anything and issue summary of words matches the changes.
Status changed to Needs work 5 months ago12:17pm 2 February 2024
Comment 5 months ago →
🇬🇧United Kingdom longwave UK
A couple of nits and a single objection, which I think we should defer until 📌 Remove 'fast_404.excluded_paths' from system.performance.yml Needs work
Pipeline finished with Success
5 months ago
Total: 497s
#87367
Pipeline finished with Success
5 months ago
Total: 618s
#87372
Status changed to Needs review 5 months ago10:53am 4 February 2024
Comment 5 months ago →
🇳🇿New Zealand quietone New Zealand
Pipeline finished with Success
5 months ago
Total: 598s
#87382
Status changed to RTBC 5 months ago4:05pm 6 February 2024
Comment 5 months ago →
🇺🇸United States smustgrave
Lot of files touched but easy to read

The changes themselves look good, so going to mark for that. But what about a follow up to discuss ignoring cpsell errors in migration yml files? Or yml files in general?
Comment 4 months ago →
🇬🇧United Kingdom longwave UK
Almost didn't commit this because of the change to views.view.test_statistics_integration.yml but on further investigation we have already committed cspell:ignore to test config already. I do think we should try to avoid this if at all possible in "real" module config though.

Committed cb328b8 and pushed to 11.x. Thanks!
Comment 4 months ago →
System Message

longwave → committed cb328b8c on 11.x
Issue #3417669 by quietone, longwave, smustgrave: Correct migrate...
Comment 4 months ago →
🇬🇧United Kingdom longwave UK
Issue credit did not save correctly.
Status changed to Fixed 4 months ago12:02pm 18 February 2024
Comment 4 months ago →
System Message
longwave → closed merge request !6357
Comment 4 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024