Contrib.social

Fix phpcs issue in the module

Open on Drupal.org ā†’
Created on 25 January 2024, 5 months ago
Updated 27 April 2024, about 2 months ago

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig layout_builder_tabs

FILE: /Users/prabue/Desktop/Projects/install-dir/web/modules/contrib/layout_builder_tabs/README.md
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
46 | WARNING | Line exceeds 80 characters; contains 89 characters
--------------------------------------------------------------------------------------------------

FILE: /Users/prabue/Desktop/Projects/install-dir/web/modules/contrib/layout_builder_tabs/layout_builder_tabs.info.yml
---------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
---------------------------------------------------------------------------------------------------------------------

FILE: /Users/prabue/Desktop/Projects/install-dir/web/modules/contrib/layout_builder_tabs/src/TwigExtension/SortByWeight.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] There must be one blank line after the last USE statement; 0 found;
17 | ERROR | [ ] The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------

Time: 266ms; Memory: 10MB

šŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India PrabuEla chennai

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @PrabuEla
  • Comment 5 months ago ā†’
    šŸ‡®šŸ‡³India PrabuEla chennai
  • Issue was unassigned.
  • Status changed to Needs review 5 months ago
  • Comment 5 months ago ā†’
    šŸ‡®šŸ‡³India PrabuEla chennai
  • Status changed to Needs work 5 months ago
  • Comment 5 months ago ā†’
    šŸ‡µšŸ‡­Philippines clarkssquared

    Hi

    I applied your patch #2 and I noticed that your patch there's one file didn't apply properly 

    āžœ  layout_builder_tabs git:(master) āœ— curl https://www.drupal.org/files/issues/2024-01-25/3416913.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1401  100  1401    0     0   2992      0 --:--:-- --:--:-- --:--:--  3019
patching file README.md
patching file layout_builder_tabs.info.yml
1 out of 1 hunks failed--saving rejects to layout_builder_tabs.info.yml.rej
patching file 'src/TwigExtension/SortByWeight.php'
āžœ  layout_builder_tabs git:(master) āœ— ..
āžœ  contrib git:(master) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml layout_builder_tabs

FILE: ...local/web/modules/contrib/layout_builder_tabs/layout_builder_tabs.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
 7 | WARNING | All dependencies must be prefixed with the project name, for
   |         | example "drupal:"
--------------------------------------------------------------------------------

Time: 210ms; Memory: 10MB

āžœ  contrib git:(master) āœ— 
āžœ  contrib git:(master) āœ—
  • First commit to issue fork.
  • Comment 5 months ago ā†’
    šŸ‡®šŸ‡³India viren18febS

    i have fixed all the reported issues by phpcs , please review

  • Status changed to Needs review 5 months ago
  • Comment 5 months ago ā†’
    šŸ‡®šŸ‡³India viren18febS
  • Comment 4 months ago ā†’
    bindu r

    Hi, Reviewed the patch #6, applies cleanly and fixed all the phpcs errors/warnings.

  • Comment 2 months ago ā†’
    System Message
    • mandclu ā†’ committed e04f0439 on 1.0.x 
      Issue #3416913 by viren18febS, PrabuEla, mandclu: Fix phpcs issue in the...
  • Status changed to Fixed 2 months ago
  • Comment 2 months ago ā†’
    šŸ‡ØšŸ‡¦Canada mandclu

    Thanks for everyone's work on this. Merged in.

  • Comment about 2 months ago ā†’
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024