Queue factory services do not conform to an interface

Left a small nitpicky but MR appears to have a failure.

Unfortunately we can't add a return type because this is already extended in contrib.

Added a change record and improved the deprecation notice.

Ah yea see what you mean about not being able to use the typehints. In that case rest looks fine.

I'm triaging RTBC issues → . I read the IS, the comments and the MR. I didn't find any unanswered questions or other work to do.

Leaving at RTBC;

Have a look at this issue, figure out which should be closed as a duplicate, and check if any changes from the duplicate issue should be incorporated.

longwave → credited fgm → .

Thanks, I did not see that issue earlier. I think that one can be closed as duplicate because:

• That one defines a new (but unused) queue.memory service, which I don't see the point in
• That one also adds a return type, but we can't do that without breaking backward compatibility

Otherwise the implementations are the same except for comments. Crediting fgm here for the work done over there.

Okay, thanks. I closed it as a duplicate.

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

I asked @longwave about potentially backporting this to 10.2 so contrib could use it earlier for 10/11 compatibility, but as far as we know the only contrib module affected is redis, so should probably see if it's a real issue before backporting API additions to a patch release.

As there is no interface it is hard to search contrib but I did find QueueFactory references in the following (amongst a lot of false positives):

https://www.drupal.org/project/aws_sqs →
https://www.drupal.org/project/beanstalkd →
https://www.drupal.org/project/mongodb →
https://www.drupal.org/project/rabbitmq →
https://www.drupal.org/project/redis →

That's enough I think we should backport just the interface to 10.2.x.

longwave → closed merge request !6310

Adds the interface, applies it to QueueDatabaseFactory, also backports the comment fixes.

That looks like just the right amount to backport.

Can we add typehints (both param and return) to the interface and implementation. I think adding a new interface with typehints is more valuable than the backport to 10.2.x. Given there is no interface I think adding typehints should be allowed.

Can't be done without breaking contrib, as per previous comment on the MR.

If we add types to the interface, we need to add them to QueueDatabaseFactory. queue_unique extends QueueDatabaseFactory and so that will break: https://git.drupalcode.org/project/queue_unique/-/blob/8.x-2.x/src/Uniqu...

Committed a5826e6 and pushed to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

Hey, I noticed that QueueDatabaseFactory was given the new interface, but QueueFactory does not yet implement the new interface. Should I open a new issue, or can that be fixed here?