Twitter logo needs to be changed

Created on 22 January 2024, 5 months ago
Updated 7 May 2024, about 2 months ago

Problem/Motivation

While going through the theme for issues I found out that twitter logo is still the old one.

Steps to reproduce

Install the theme and check for the twitter logo in the footer

Proposed resolution

Icon needs to be updated with new twitter logo X

Remaining tasks

none

User interface changes

Yes

API changes

none

Data model changes

none

๐Ÿ“Œ Task
Status

Active

Version

3.0

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hamid.ali

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Hamid.ali
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia chetan 11

    chetan 11 โ†’ made their first commit to this issueโ€™s fork.

  • Assigned to PrabuEla
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia PrabuEla chennai
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia adarshv

    Hello @Hamid.ali,

    To change the Twitter logo, you need to add/import the library "https://cdn.jsdelivr.net/npm/bootstrap-icons@1.11.3/font/bootstrap-icons.min.css" and replace the icon class "bi bi-twitter" with "bi bi-twitter-x" in the "OpenChurch Core" module.

  • First commit to issue fork.
  • Merge request !33.0.x โ†’ (Open) created by akhil_01
  • I have created MR!3 for the above issue,

    In this we updated "theme-settings.php", "openchurch_theme.settings.yml", "openchurch_theme.schema.yml", "openchurch_theme.libraries.yml"

    Also we need to update some codes on the "openchurch_core" Module.

    openchurch_core.module

    Apply inside of

    "openchurch_core_library_info_alter()"

    this hook

     if ($icons_min_css = theme_get_setting('icons_min_css')) {
          $libraries['icons-min']['css']['component'] = [$icons_min_css => []];
        }
    

    openchurch-core-footer.html.twig

    Apply inside of {% if footer_twitter %} this condition.

    <li class="list-inline-item"><a href="{{ footer_twitter }}"><i class="bi bi-twitter-x"></i></a></li>

  • Issue was unassigned.
  • ๐Ÿ‡ฎ๐Ÿ‡นItaly apaderno Brescia, ๐Ÿ‡ฎ๐Ÿ‡น

    I am resetting the Assigned field, since the person to whom this issue was assigned did not work on this issue since more than 24 hours ago.

Production build 0.69.0 2024